better error messages for alert handlers

CHANGELOG.md

@@ -13,8 +13,9 @@
 ### Bugfixes
 - [#199](https://github.com/influxdata/kapacitor/issues/199): BREAKING: Various fixes for the Alerta integration.
     The `event` property has been removed from the Alerta node and is now set as the value of the alert ID.
+- [#232](https://github.com/influxdata/kapacitor/issues/232): Better error message for alert integrations. Better error message for VictorOps 404 response.
 
-## v0.10.1 [2013-02-08]
+## v0.10.1 [2016-02-08]
 
 ### Release Notes
 

services/alerta/service.go

@@ -4,6 +4,7 @@ import (
 	"bytes"
 	"encoding/json"
 	"errors"
+	"fmt"
 	"io/ioutil"
 	"log"
 	"net/http"
@@ -94,7 +95,7 @@ func (s *Service) Alert(token, resource, event, environment, severity, status, g
 		type response struct {
 			Message string `json:"message"`
 		}
-		r := &response{Message: "failed to understand Alerta response: " + string(body)}
+		r := &response{Message: fmt.Sprintf("failed to understand Alerta response. code: %d content: %s", resp.StatusCode, string(body))}
 		b := bytes.NewReader(body)
 		dec := json.NewDecoder(b)
 		dec.Decode(r)

services/deadman/config.go

@@ -12,7 +12,7 @@ const (
 	// Default deadman's switch threshold
 	DefaultThreshold = float64(0)
 	// Default deadman's switch id
-	DefaultId = "node 'NODE_NAME' in task '{{ .TaskName }}'"
+	DefaultId = "{{ .Group }}:NODE_NAME for task '{{ .TaskName }}'"
 	// Default deadman's switch message
 	DefaultMessage = "{{ .ID }} is {{ if eq .Level \"OK\" }}alive{{ else }}dead{{ end }}: {{ index .Fields \"emitted\" | printf \"%0.3f\" }} points/INTERVAL."
 )

services/hipchat/service.go

@@ -4,6 +4,7 @@ import (
 	"bytes"
 	"encoding/json"
 	"errors"
+	"fmt"
 	"io/ioutil"
 	"log"
 	"net/http"
@@ -94,7 +95,7 @@ func (s *Service) Alert(room, token, message string, level kapacitor.AlertLevel)
 		type response struct {
 			Error string `json:"error"`
 		}
-		r := &response{Error: "failed to understand HipChat response: " + string(body)}
+		r := &response{Error: fmt.Sprintf("failed to understand HipChat response. code: %d content: %s", resp.StatusCode, string(body))}
 		b := bytes.NewReader(body)
 		dec := json.NewDecoder(b)
 		dec.Decode(r)

services/opsgenie/service.go

@@ -4,6 +4,7 @@ import (
 	"bytes"
 	"encoding/json"
 	"errors"
+	"fmt"
 	"io/ioutil"
 	"log"
 	"net/http"
@@ -115,7 +116,7 @@ func (s *Service) Alert(teams []string, recipients []string, messageType, messag
 		type response struct {
 			Message string `json:"message"`
 		}
-		r := &response{Message: "failed to understand OpsGenie response: " + string(body)}
+		r := &response{Message: fmt.Sprintf("failed to understand OpsGenie response. code: %d content: %s", resp.StatusCode, string(body))}
 		b := bytes.NewReader(body)
 		dec := json.NewDecoder(b)
 		dec.Decode(r)

services/pagerduty/service.go

@@ -4,6 +4,7 @@ import (
 	"bytes"
 	"encoding/json"
 	"errors"
+	"fmt"
 	"io/ioutil"
 	"log"
 	"net/http"
@@ -80,7 +81,7 @@ func (s *Service) Alert(incidentKey, desc string, details interface{}) error {
 		type response struct {
 			Message string `json:"message"`
 		}
-		r := &response{Message: "failed to understand PagerDuty response: " + string(body)}
+		r := &response{Message: fmt.Sprintf("failed to understand PagerDuty response. code: %d content: %s", resp.StatusCode, string(body))}
 		b := bytes.NewReader(body)
 		dec := json.NewDecoder(b)
 		dec.Decode(r)

services/sensu/service.go

@@ -4,6 +4,7 @@ import (
 	"bytes"
 	"encoding/json"
 	"errors"
+	"fmt"
 	"io/ioutil"
 	"log"
 	"net/http"
@@ -74,7 +75,7 @@ func (s *Service) Alert(name, output string, level kapacitor.AlertLevel) error {
 		type response struct {
 			Error string `json:"error"`
 		}
-		r := &response{Error: "failed to understand Sensu response: " + string(body)}
+		r := &response{Error: fmt.Sprintf("failed to understand Sensu response. code: %d content: %s", resp.StatusCode, string(body))}
 		b := bytes.NewReader(body)
 		dec := json.NewDecoder(b)
 		dec.Decode(r)

services/slack/service.go

@@ -4,6 +4,7 @@ import (
 	"bytes"
 	"encoding/json"
 	"errors"
+	"fmt"
 	"io/ioutil"
 	"log"
 	"net/http"
@@ -90,7 +91,7 @@ func (s *Service) Alert(channel, message string, level kapacitor.AlertLevel) err
 		type response struct {
 			Error string `json:"error"`
 		}
-		r := &response{Error: "failed to understand Slack response: " + string(body)}
+		r := &response{Error: fmt.Sprintf("failed to understand Slack response. code: %d content: %s", resp.StatusCode, string(body))}
 		b := bytes.NewReader(body)
 		dec := json.NewDecoder(b)
 		dec.Decode(r)

services/talk/service.go

@@ -4,6 +4,8 @@ import (
 	"bytes"
 	"encoding/json"
 	"errors"
+	"fmt"
+	"io/ioutil"
 	"log"
 	"net/http"
 )
@@ -49,10 +51,14 @@ func (s *Service) Alert(title, text string) error {
 	}
 	defer resp.Body.Close()
 	if resp.StatusCode != http.StatusOK {
+		body, err := ioutil.ReadAll(resp.Body)
+		if err != nil {
+			return err
+		}
 		type response struct {
 			Error string `json:"error"`
 		}
-		r := &response{Error: "failed to understand Talk response"}
+		r := &response{Error: fmt.Sprintf("failed to understand Talk response. code: %d content: %s", resp.StatusCode, string(body))}
 		dec := json.NewDecoder(resp.Body)
 		dec.Decode(r)
 		return errors.New(r.Error)

services/victorops/service.go

@@ -4,6 +4,7 @@ import (
 	"bytes"
 	"encoding/json"
 	"errors"
+	"fmt"
 	"io/ioutil"
 	"log"
 	"net/http"
@@ -73,14 +74,17 @@ func (s *Service) Alert(routingKey, messageType, message, entityID string, t tim
 	}
 	defer resp.Body.Close()
 	if resp.StatusCode != http.StatusOK {
+		if resp.StatusCode == http.StatusNotFound {
+			return errors.New("URL or API key not found: 404")
+		}
 		body, err := ioutil.ReadAll(resp.Body)
 		if err != nil {
 			return err
 		}
 		type response struct {
 			Message string `json:"message"`
 		}
-		r := &response{Message: "failed to understand VictorOps response: " + string(body)}
+		r := &response{Message: fmt.Sprintf("failed to understand VictorOps response. code: %d content: %s", resp.StatusCode, string(body))}
 		b := bytes.NewReader(body)
 		dec := json.NewDecoder(b)
 		dec.Decode(r)