Skip to content

Commit

Permalink
Have the skeleton compile unit construction method take the CU it
Browse files Browse the repository at this point in the history
is constructing from as an input and keep the same unique identifier.
We can use this to connect items which must stay in the .o file
(e.g. pubnames and pubtypes) to the skeleton cu rather than having
duplicate unique numbers for the sections and needing to do lookups
based on MDNode.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@189293 91177308-0d34-0410-b5e6-96231b3b80d8
  • Loading branch information
echristo committed Aug 26, 2013
1 parent 4c65ab7 commit a9b2c79
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
10 changes: 5 additions & 5 deletions lib/CodeGen/AsmPrinter/DwarfDebug.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1032,7 +1032,7 @@ void DwarfDebug::finalizeModuleInfo() {
TheCU->addUInt(TheCU->getCUDie(), dwarf::DW_AT_GNU_dwo_id,
dwarf::DW_FORM_data8, ID);
// Now construct the skeleton CU associated.
CompileUnit *SkCU = constructSkeletonCU(CUI->first);
CompileUnit *SkCU = constructSkeletonCU(TheCU);
// This should be a unique identifier when we want to build .dwp files.
SkCU->addUInt(SkCU->getCUDie(), dwarf::DW_AT_GNU_dwo_id,
dwarf::DW_FORM_data8, ID);
Expand Down Expand Up @@ -2685,12 +2685,12 @@ void DwarfDebug::emitDebugInlineInfo() {
// DW_AT_low_pc, DW_AT_high_pc, DW_AT_ranges, DW_AT_dwo_name, DW_AT_dwo_id,
// DW_AT_ranges_base, DW_AT_addr_base. If DW_AT_ranges is present,
// DW_AT_low_pc and DW_AT_high_pc are not used, and vice versa.
CompileUnit *DwarfDebug::constructSkeletonCU(const MDNode *N) {
DICompileUnit DIUnit(N);
CompileUnit *DwarfDebug::constructSkeletonCU(const CompileUnit *CU) {
DICompileUnit DIUnit(CU->getNode());

DIE *Die = new DIE(dwarf::DW_TAG_compile_unit);
CompileUnit *NewCU =
new CompileUnit(GlobalCUIndexCount++, Die, N, Asm, this, &SkeletonHolder);
CompileUnit *NewCU = new CompileUnit(CU->getUniqueID(), Die, CU->getNode(),
Asm, this, &SkeletonHolder);

NewCU->addLocalString(Die, dwarf::DW_AT_GNU_dwo_name,
DIUnit.getSplitDebugFilename());
Expand Down
2 changes: 1 addition & 1 deletion lib/CodeGen/AsmPrinter/DwarfDebug.h
Original file line number Diff line number Diff line change
Expand Up @@ -559,7 +559,7 @@ class DwarfDebug {

/// \brief Construct the split debug info compile unit for the debug info
/// section.
CompileUnit *constructSkeletonCU(const MDNode *);
CompileUnit *constructSkeletonCU(const CompileUnit *CU);

/// \brief Emit the local split abbreviations.
void emitSkeletonAbbrevs(const MCSection *);
Expand Down

0 comments on commit a9b2c79

Please sign in to comment.