Tags: eic/EICrecon
Tags
feat(ci): runs-on: ubuntu-latest -> ubuntu-22.04 (#1687) ### Briefly, what does this PR introduce? This PR updates the target operating system for CI jobs, from ubuntu-latest to a more explicit ubuntu-22.04. This is in part to avoid the automatic update of implicit ubuntu-latest that will break everything (#1686), and in part because it makes sense to be explicit about the target operating system. ### What kind of change does this PR introduce? - [ ] Bug fix (issue #__) - [x] New feature (issue actions/runner-images#10636) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [ ] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? No. ### Does this PR change default behavior? No.
Update of the BIC sampling fractions (#1664) ### Briefly, what does this PR introduce? Sampling fractions of the BIC ScFi and imaging layers have been updated using 5 GeV electrons generated at eta = 0. Only the constant sampling fractions are provided this time. The energy- and eta-dependent ones will be provided next time referring to the comments on the last BIC sampling fraction PR. ### What kind of change does this PR introduce? - [ ] Bug fix (issue #__) - [x] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [x] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? No ### Does this PR change default behavior? No
Fix JANA2-related deprecation warnings and TODOs (#1622) ### Briefly, what does this PR introduce? This cleans up the EICrecon compilation output by fixing some deprecation warnings coming from JANA2. It also removes some JANA2-related TODO comments. It updates a test case to no longer use a template method that hasn't been deprecated, but is about to be. ### What kind of change does this PR introduce? - [ ] Bug fix (issue #__) - [ ] New feature (issue #__) - [ ] Documentation update - [x] Other: Fixes deprecation warnings ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [ ] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? No ### Does this PR change default behavior? No
added PrimaryVertices factory (subCollection of CentralTrackVertices) (… …#1609) ### Briefly, what does this PR introduce? ### What kind of change does this PR introduce? - [ ] Bug fix (issue #__) - [X] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [ ] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? ### Does this PR change default behavior? --------- Co-authored-by: Xin Dong <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Xin Dong <[email protected]> Co-authored-by: Dmitry Kalinkin <[email protected]>
lowered the amount of distance neighbor hits in topoclustering in the… … ZDC (#1532) ### Briefly, what does this PR introduce? Redefines neighboring subcell hits in the ZDC (in the context of topo clustering) to be the nearest neighbors only for hits in the same layer, and the same position for hits in adjacent layers. This change reduces the cases where showers from different particles are merged into a single cluster ### What kind of change does this PR introduce? - [ ] Bug fix (issue #__) - [ ] New feature (issue #__) - [ ] Documentation update - [X] Other: parameter tweak ### Please check if this PR fulfills the following: - [X] Tests for the changes have been added - [X] Documentation has been added / updated - [X] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? no. ### Does this PR change default behavior? yes. Changes the default behavior of the topo clustering in the ZDC --------- Co-authored-by: Dmitry Kalinkin <[email protected]> Co-authored-by: Derek M Anderson <[email protected]>
Add one-to-one relation with raw tracker/calorimeter hit for reconstr… …ucted tracker/calorimeter hit (#1535) ### Briefly, what does this PR introduce? Add one-to-one relation with raw tracker/calorimeter hit for reconstructed tracker/calorimeter hit. Contingent on eic/EDM4eic#86. ### What kind of change does this PR introduce? - [ ] Bug fix (issue #__) - [ ] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [ ] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? ### Does this PR change default behavior? --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Dmitry Kalinkin <[email protected]> Co-authored-by: Wouter Deconinck <[email protected]>
implementation of ambiguity resolution solver from ACTS (#1383) ### Briefly, what does this PR introduce? * implementation of ambiguity resolution solver from ACTS; removing duplicate tracks from realistic seeding * new factory called after CKFtracking; taking CKFtracking outputs as inputs; provides a set of output collections ### What kind of change does this PR introduce? - [ ] Bug fix (issue #__) - [x] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [x] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? * No change required; ### Does this PR change default behavior? * adding 3 PodIO output collection --------- Co-authored-by: Minjung Kim <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Minjung Kim <[email protected]> Co-authored-by: Wouter Deconinck <[email protected]> Co-authored-by: Dmitry Kalinkin <[email protected]> Co-authored-by: Minjung Kim <[email protected]> Co-authored-by: Barak Schmookler <[email protected]>
PreviousNext