Low level client #29
Merged
Low level client #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a fair bit more verbose, but it lets users set header parameters if they want to, and it allows us to build infrastructure for request retries in the future, in a more generic way.
einarmo
added a commit
that referenced
this pull request
Dec 15, 2024
* Make client service calls use a request builder This is a fair bit more verbose, but it lets users set header parameters if they want to, and it allows us to build infrastructure for request retries in the future, in a more generic way. * Docs, some refactoring * Add test for transfer subscriptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the client to use a request-builder approach, making it possible to customize requests more, and also to do stuff like we now do in a test, transfer subscriptions without being in the same session.