Dynamic structs #48
Merged
Dynamic structs #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a really powerful feature that allows you to use the type definition to encode and decode structs into a vec of variants. This should with a little more work make it possible to create a client that can read from any server without needing codegen for the types on that server.
They really do fit better there, even if they are primarily useful for the client.
einarmo
added a commit
that referenced
this pull request
Dec 15, 2024
Support for serializing and deserializing structs using just the DataTypeDefinition and encoding IDs. This is an essential feature for creating generic clients, but it is not trivial. The current solution is actually far more powerful than what codegen is capable of. We might want to think about expanding the macros to support structures with optional fields and unions, but that can come later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for serializing and deserializing structs using just the DataTypeDefinition and encoding IDs.
This is an essential feature for creating generic clients, but it is not trivial. The current solution is actually far more powerful than what codegen is capable of. We might want to think about expanding the macros to support structures with optional fields and unions, but that can come later.