Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Class object #10

Merged
merged 1 commit into from
Feb 10, 2016
Merged

Add Class object #10

merged 1 commit into from
Feb 10, 2016

Conversation

amacneil
Copy link
Contributor

I needed access to list/create the Class objects in quickbooks. It's a pain since that is a reserved word in python, which I assume is why this object was left out in the first place.

Anyway, I just called it TrackingClass to avoid any conflicts. Let me know if you can think of a better name.

ej2 added a commit that referenced this pull request Feb 10, 2016
@ej2 ej2 merged commit f972fd4 into ej2:master Feb 10, 2016
@ej2
Copy link
Owner

ej2 commented Feb 10, 2016

Excellent. Thank you.

@grantmcconnaughey
Copy link
Contributor

FYI, this object can be named Class. class is a reserved word, Class isn't.

@ej2
Copy link
Owner

ej2 commented Feb 10, 2016

Good point. I will change it.

@amacneil
Copy link
Contributor Author

Yeah, I tried that originally. But you have to name the file something other than class.py otherwise it can't be imported, and by convention it should match the class name.

@grantmcconnaughey
Copy link
Contributor

Touché.

@amacneil
Copy link
Contributor Author

You could call the file cls.py or something I guess. Might be confusing/unexpected for users though. Really I have no idea what QB were thinking calling their domain object Class.

@ej2
Copy link
Owner

ej2 commented Feb 10, 2016

FYI: I left the file named trackingclass.py

@grantmcconnaughey
Copy link
Contributor

If we had a dollar for every time we said "I have no idea what QB was thinking..." we wouldn't need to work anymore.

@amacneil
Copy link
Contributor Author

Thanks for quick release 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants