Use new support for stream options on SMTP connect, add tests for it

ejjjjj · May 16, 2013 · 85136af · 85136af
1 parent 9cbce11
commit 85136af
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/class.phpmailer.php b/class.phpmailer.php
@@ -1059,12 +1059,13 @@ protected function SmtpSend($header, $body) {
   /**
    * Initiates a connection to an SMTP server.
    * Returns false if the operation failed.
+   * @param array $options An array of options compatible with stream_context_create()
    * @uses SMTP
    * @access public
    * @throws phpmailerException
    * @return bool
    */
-  public function SmtpConnect() {
+  public function SmtpConnect($options = array()) {
     if(is_null($this->smtp)) {
       $this->smtp = new SMTP;
     }
@@ -1092,7 +1093,7 @@ public function SmtpConnect() {
         $host = $hostinfo[1];
         $port = $hostinfo[2];
       }
-      if ($this->smtp->Connect(($ssl ? 'ssl://':'').$host, $port, $this->Timeout)) {
+      if ($this->smtp->Connect(($ssl ? 'ssl://':'').$host, $port, $this->Timeout, $options)) {
         try {
           if ($this->Helo) {
             $hello = $this->Helo;

diff --git a/test/phpmailerTest.php b/test/phpmailerTest.php
@@ -967,6 +967,9 @@ function test_SmtpConnect()
     $this->Mail->SmtpClose();
     $this->Mail->Host = "localhost:12345;10.10.10.10:54321;".$_REQUEST['mail_host'];
     $this->assertTrue($this->Mail->SmtpConnect(), 'SMTP multi-connect failed');
+    $this->Mail->SmtpClose();
+    $this->Mail->Host = $_REQUEST['mail_host'];
+    $this->assertTrue($this->Mail->SmtpConnect(array('socket' => array('bindto' => '0:7000'))), 'SMTP connect with options failed');
   }
 
   /**