Skip to content

Commit

Permalink
improvement(service): LLMNR: split into llmnr-tcp and llmnr-udp
Browse files Browse the repository at this point in the history
TCP implementation cannot work with destination addresses.
  • Loading branch information
marcosfrm authored and erig0 committed Aug 5, 2021
1 parent 4cd7b33 commit 64b3a6b
Show file tree
Hide file tree
Showing 5 changed files with 21 additions and 5 deletions.
2 changes: 2 additions & 0 deletions config/Makefile.am
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,8 @@ CONFIG_FILES = \
services/ldap.xml \
services/libvirt-tls.xml \
services/libvirt.xml \
services/llmnr-tcp.xml \
services/llmnr-udp.xml \
services/llmnr.xml \
services/managesieve.xml \
services/matrix.xml \
Expand Down
6 changes: 6 additions & 0 deletions config/services/llmnr-tcp.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<service>
<short>LLMNR (TCP)</short>
<description>Link-Local Multicast Name Resolution (LLMNR) allows both IPv4 and IPv6 hosts to perform name resolution for hosts on the same local link.</description>
<port protocol="tcp" port="5355"/>
</service>
7 changes: 7 additions & 0 deletions config/services/llmnr-udp.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
<?xml version="1.0" encoding="utf-8"?>
<service>
<short>LLMNR (UDP)</short>
<description>Link-Local Multicast Name Resolution (LLMNR) allows both IPv4 and IPv6 hosts to perform name resolution for hosts on the same local link.</description>
<port protocol="udp" port="5355"/>
<destination ipv4="224.0.0.252" ipv6="ff02::1:3"/>
</service>
9 changes: 4 additions & 5 deletions config/services/llmnr.xml
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
<?xml version="1.0" encoding="utf-8"?>
<service>
<short>Link-Local Multicast Name Resolution (LLMNR)</short>
<description>LLMNR allows both IPv4 and IPv6 hosts to perform name resolution for hosts on the same local link.</description>
<port protocol="tcp" port="5355"/>
<port protocol="udp" port="5355"/>
<destination ipv4="224.0.0.252" ipv6="ff02::1:3"/>
<short>LLMNR</short>
<description>Link-Local Multicast Name Resolution (LLMNR) allows both IPv4 and IPv6 hosts to perform name resolution for hosts on the same local link.</description>
<include service="llmnr-tcp"/>
<include service="llmnr-udp"/>
</service>
2 changes: 2 additions & 0 deletions po/POTFILES.in
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,8 @@ config/services/ldap.xml
config/services/libvirt-tls.xml
config/services/libvirt.xml
config/services/lightning-network.xml
config/services/llmnr-tcp.xml
config/services/llmnr-udp.xml
config/services/llmnr.xml
config/services/managesieve.xml
config/services/matrix.xml
Expand Down

0 comments on commit 64b3a6b

Please sign in to comment.