Skip to content

Commit

Permalink
Disable hidden symbols on unoptimized builds in order to improve test…
Browse files Browse the repository at this point in the history
… backtraces (flutter#26409)
  • Loading branch information
jason-simmons authored May 27, 2021
1 parent 2e76b12 commit 7799323
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
2 changes: 1 addition & 1 deletion DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ allowed_hosts = [
]

deps = {
'src': 'https://github.com/flutter/buildroot.git' + '@' + 'd86d028552a050f25fb25bf9163f7df0cee9f9a4',
'src': 'https://github.com/flutter/buildroot.git' + '@' + 'ef50dec1f85ee435e967505f460d2c0ce6fde58e',

# Fuchsia compatibility
#
Expand Down
3 changes: 3 additions & 0 deletions tools/gn
Original file line number Diff line number Diff line change
Expand Up @@ -294,6 +294,9 @@ def to_gn_args(args):
# even with -fPIC everywhere.
# gn_args['enable_profiling'] = args.runtime_mode != 'release' and args.android_cpu != 'x86'

# Make symbols visible in order to enable symbolization of unit test crash backtraces on Linux
gn_args['disable_hidden_visibility'] = args.target_os == 'linux' and args.unoptimized

if args.arm_float_abi:
gn_args['arm_float_abi'] = args.arm_float_abi

Expand Down

0 comments on commit 7799323

Please sign in to comment.