Make rasterFinishWallTime required (flutter#27142)

elancom · Jul 7, 2021 · dd17c08 · dd17c08
1 parent 44b04ec
commit dd17c08
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/lib/ui/platform_dispatcher.dart b/lib/ui/platform_dispatcher.dart
@@ -1182,7 +1182,7 @@ class FrameTiming {
     required int buildFinish,
     required int rasterStart,
     required int rasterFinish,
-    int rasterFinishWallTime = -1,
+    required int rasterFinishWallTime,
     int frameNumber = -1,
   }) {
     return FrameTiming._(<int>[
@@ -1191,7 +1191,7 @@ class FrameTiming {
       buildFinish,
       rasterStart,
       rasterFinish,
-      if (rasterFinishWallTime == -1) rasterFinish else rasterFinishWallTime,
+      rasterFinishWallTime,
       frameNumber,
     ]);
   }

diff --git a/lib/web_ui/lib/src/engine/profiler.dart b/lib/web_ui/lib/src/engine/profiler.dart
@@ -198,6 +198,7 @@ void frameTimingsOnRasterFinish() {
     buildFinish: _buildFinishMicros,
     rasterStart: _rasterStartMicros,
     rasterFinish: _rasterFinishMicros,
+    rasterFinishWallTime: _rasterFinishMicros,
   ));
   _vsyncStartMicros = -1;
   _buildStartMicros = -1;

diff --git a/lib/web_ui/lib/src/ui/platform_dispatcher.dart b/lib/web_ui/lib/src/ui/platform_dispatcher.dart
@@ -210,7 +210,7 @@ class FrameTiming {
     required int buildFinish,
     required int rasterStart,
     required int rasterFinish,
-    int rasterFinishWallTime = -1,
+    required int rasterFinishWallTime,
     int frameNumber = 1,
   }) {
     return FrameTiming._(<int>[
@@ -219,7 +219,7 @@ class FrameTiming {
       buildFinish,
       rasterStart,
       rasterFinish,
-      if (rasterFinishWallTime == -1) rasterFinish else rasterFinishWallTime,
+      rasterFinishWallTime,
       frameNumber,
     ]);
   }