Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s3-sqs input: log a lambda event summary in case of errors #860

Merged
merged 9 commits into from
Dec 13, 2024
Merged

s3-sqs input: log a lambda event summary in case of errors #860

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0757e7b
Add lambda event summary for aws:sqs events
zmoog Nov 29, 2024
9f0dcb2
Address linter complaints
zmoog Nov 29, 2024
088ba33
Set max_records to 20
zmoog Nov 29, 2024
df1afbd
Address review comments
zmoog Dec 11, 2024
e88536d
Fix linter complaints
zmoog Dec 11, 2024
e5e43c4
Update tests
zmoog Dec 11, 2024
b0ac84b
Address review comments
zmoog Dec 11, 2024
a8f9c07
Break out of the loop when we reached max_records
zmoog Dec 11, 2024
99c147c
Make linter happy again
zmoog Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address review comments
  • Loading branch information
@zmoog
zmoog committed Dec 11, 2024
commit b0ac84b5eb9a87dde92590f5b612b3e3d3609905
6 changes: 3 additions & 3 deletions handlers/aws/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,11 +203,11 @@ def summarize_lambda_event(event: dict[str, Any], max_records: int = 10) -> dict
# Update the summary with the new information.
summary["aws:sqs"] = aws_sqs_summary

except Exception as e:
shared_logger.exception("error summarizing lambda event", exc_info=e)
except Exception as exc:
shared_logger.exception("error summarizing lambda event", exc_info=exc)
# We add an error message to the summary so users know if the summary
# is incomplete.
summary["error"] = str(e)
summary["error"] = str(exc)

return summary

Expand Down
Loading