High contrast mode support #8232
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- at this point it's creating more false positives with nested template literals than it is being helpful
…omBar, EuiToken (#8225)
|
I'll push up any minor visual tweaks/bugfixes directly to this PR. Already noticing one or two in the final smoke test 😅 |
cee-chen
force-pushed
the
high-contrast-mode
branch
from
e75d2fa to
50502ee
Compare
mgadewoll
reviewed
Dec 12, 2024
|
ℹ️ We won't merge this PR just yet as we first need to rebase and update Borealis with these changes. Otherwise the Borealis feature branch would be blocked from releases. |
- enables workspace EUI version for docusaurus-theme - fixes theme vs colorMode setting on EuiProvider in EUI+
cee-chen
force-pushed
the
high-contrast-mode
branch
from
8d61392 to
578de0b
Compare
|
I forced pushed to remove some of the component fixes I pre-emptively pushed up. I'm just going to open a new (last 💀) PR with various fixes and updates I found in my final review pass: #8234 |
|
Preview staging links for this PR:
|
💚 Build Succeeded
History
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes #8133. See also #7509 (comment)
Note
This is a feature branch. This means that it contains a massive changeset that has been reviewed in atomic chunks. Please see the below individual PRs for discussions, changes, and reviews:
highContrastModeset up and documentation #8142QA
General checklist
@defaultif default values are missing) and playground toggles- [ ] Checked Code Sandbox works for any docs examples- [ ] If applicable, added the breaking change issue label (and filled out the breaking change checklist)