[ML] Anomaly Explorer: Fix Anomalies Table pagination #214714

rbrtj · 2025-03-17T11:14:27Z

Includes a fix for #213424 and a follow up to #203224 (comment)

Rewrites anomalies_table in typescript
Decouples anomalies table state into an individual service
Fixes an issue where anomalies table pagination wouldn't reset to 0 after changing significant properties of the view, causing the table data to refetch

…rvice && fix table pagination

elasticmachine · 2025-03-17T12:11:51Z

Pinging @elastic/ml-ui (:ml)

peteharverson

Tested in the Anomaly Explorer and SMV and LGTM

darnautov

Great job on the fix, and many thanks for going the extra mile in refactoring it to TypeScript! I’ve left some comments—feel free to reach out if you need any help.

x-pack/platform/plugins/shared/ml/common/types/results.ts

...platform/plugins/shared/ml/public/application/components/anomalies_table/anomalies_table.tsx

darnautov · 2025-03-20T10:33:11Z

...platform/plugins/shared/ml/public/application/components/anomalies_table/anomalies_table.tsx

+              // eslint-disable-next-line no-console
+              console.log('Error fetching category definition for row item.', error);


I know you just refactored it to typescript, but I wonder if we should surface this error to the user 🤔

Yeah, we definitely shouldn't expose the error to the user, removed in 726fe10
Should we add some kind of error toast? Wdyt @darnautov?

Replacing the console.log with an error toast if there's an error fetching the category definition sounds a good idea.

x-pack/platform/plugins/shared/ml/public/application/explorer/anomaly_table_state_service.ts

darnautov · 2025-03-20T10:51:26Z

x-pack/platform/plugins/shared/ml/public/application/explorer/anomaly_table_state_service.ts

+                  tableDataLoading: false,
+                })),
+                catchError((error) => {
+                  return of({ tableData: null, tableDataLoading: false });


Is it ok to silently fail here?

I believe there was no error handling previously, so I just reused the old code. However, it would be nice to handle errors here - maybe we should add some toast messages? wdyt?

I reckon it’d be better to show an error message instead of the table in this case, especially since we want to implement the anomalies table as an embeddable. @peteharverson WDYT?

Yes can we show a callout rather than the table, similar to what we do (I think) with the anomaly charts and swim lane?

x-pack/platform/plugins/shared/ml/public/application/explorer/anomaly_table_state_service.ts

darnautov

The fix and TS refactoring LGTM, great work on this! And good to see an enhancement with reduced API calls.

elasticmachine · 2025-03-24T10:53:52Z

💚 Build Succeeded

Buildkite Build
Commit: 5222105

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`ml`	2402	2403	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`ml`	5.4MB	5.4MB	+2.5KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
`ml`	106	107	+1

History

💚 Build #286154 succeeded 7dea1c4
💚 Build #285333 succeeded 66c9e4d
💚 Build #284594 succeeded 87d81e1
💔 Build #284517 failed f5168de
💔 Build #284508 failed 3ff4063
💔 Build #284485 failed 3d43372

cc @rbrtj

kibanamachine · 2025-03-24T11:39:41Z

Starting backport for target branches: 8.16, 8.17, 8.18, 8.x

https://github.com/elastic/kibana/actions/runs/14034322058

Includes a fix for elastic#213424 and a follow up to elastic#203224 (comment) * Rewrites anomalies_table in typescript * Decouples anomalies table state into an individual service * Fixes an issue where anomalies table pagination wouldn't reset to 0 after changing significant properties of the view, causing the table data to refetch (cherry picked from commit ab78050)

kibanamachine · 2025-03-24T11:46:21Z

💔 Some backports could not be created

Status	Branch	Result
❌	8.16	Backport failed because of merge conflicts
❌	8.17	Backport failed because of merge conflicts
✅	8.18
✅	8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 214714

Questions ?

Please refer to the Backport tool documentation

Includes a fix for elastic#213424 and a follow up to elastic#203224 (comment) * Rewrites anomalies_table in typescript * Decouples anomalies table state into an individual service * Fixes an issue where anomalies table pagination wouldn't reset to 0 after changing significant properties of the view, causing the table data to refetch

#215669) # Backport This will backport the following commits from `main` to `8.18`: - [[ML] Anomaly Explorer: Fix Anomalies Table pagination (#214714)](#214714)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)  Co-authored-by: Robert Jaszczurek <[email protected]>

…#215670) # Backport This will backport the following commits from `main` to `8.x`: - [[ML] Anomaly Explorer: Fix Anomalies Table pagination (#214714)](#214714)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)  Co-authored-by: Robert Jaszczurek <[email protected]>

Includes a fix for elastic#213424 and a follow up to elastic#203224 (comment) * Rewrites anomalies_table in typescript * Decouples anomalies table state into an individual service * Fixes an issue where anomalies table pagination wouldn't reset to 0 after changing significant properties of the view, causing the table data to refetch

decouple anomalies table state from explorer state into individual se…

3d43372

…rvice && fix table pagination

rbrtj self-assigned this Mar 17, 2025

rbrtj requested a review from a team as a code owner March 17, 2025 11:14

rbrtj added 2 commits March 17, 2025 12:48

add getAnomaliesTableDataResult type

627b31e

fix lint issues

3ff4063

rbrtj added release_note:fix backport:prev-major Backport to (8.x, 8.18, 8.17, 8.16) the previous major branch and other branches in development backport:version Backport to applied version labels v9.1.0 :ml Team:ML Team label for ML (also use :ml) labels Mar 17, 2025

rbrtj added 2 commits March 17, 2025 13:26

fix more lint errors

f5168de

fix anomaly details

87d81e1

peteharverson self-requested a review March 17, 2025 15:22

peteharverson mentioned this pull request Mar 17, 2025

[ML] Migrate Javascript files to Typescript #153894

Open

41 tasks

peteharverson approved these changes Mar 18, 2025

View reviewed changes

rbrtj requested a review from darnautov March 18, 2025 14:36

Merge branch 'main' into ml-anomalies-table-pagination-fix

66c9e4d

darnautov reviewed Mar 20, 2025

View reviewed changes

rbrtj added 8 commits March 21, 2025 12:24

examplesByJobId type update

6399053

add comparator for anomaliesTable memo

3dc7b17

update mouseOverRecordRef type

3aaac48

use named function in useEffect resetExpandedRowMap

9361bcd

remove console error log

726fe10

onTableChange type fix

4d6f276

anomaly details utils - simplify conditional checks

4186113

anomaly table state service - improve data loading

7dea1c4

rbrtj requested a review from darnautov March 21, 2025 13:36

Merge branch 'main' into ml-anomalies-table-pagination-fix

5222105

darnautov approved these changes Mar 24, 2025

View reviewed changes

rbrtj mentioned this pull request Mar 24, 2025

[ML] Anomaly Explorer: Improve Error Handling in Anomalies Table #215666

Open

rbrtj merged commit ab78050 into elastic:main Mar 24, 2025
9 checks passed

kibanamachine mentioned this pull request Mar 24, 2025

[8.18] [ML] Anomaly Explorer: Fix Anomalies Table pagination (#214714) #215669

Merged

kibanamachine mentioned this pull request Mar 24, 2025

[8.x] [ML] Anomaly Explorer: Fix Anomalies Table pagination (#214714) #215670

Merged

kibanamachine added the v8.18.0 label Mar 24, 2025

kibanamachine added the v8.19.0 label Mar 24, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ML] Anomaly Explorer: Fix Anomalies Table pagination #214714

[ML] Anomaly Explorer: Fix Anomalies Table pagination #214714

rbrtj commented Mar 17, 2025 •

edited by kibanamachine

Loading

elasticmachine commented Mar 17, 2025

peteharverson left a comment

darnautov left a comment

darnautov Mar 20, 2025

rbrtj Mar 21, 2025

peteharverson Mar 24, 2025

darnautov Mar 20, 2025

rbrtj Mar 21, 2025 •

edited

Loading

darnautov Mar 24, 2025

peteharverson Mar 24, 2025

darnautov left a comment

elasticmachine commented Mar 24, 2025

kibanamachine commented Mar 24, 2025

kibanamachine commented Mar 24, 2025

		// eslint-disable-next-line no-console
		console.log('Error fetching category definition for row item.', error);

[ML] Anomaly Explorer: Fix Anomalies Table pagination #214714

[ML] Anomaly Explorer: Fix Anomalies Table pagination #214714

Conversation

rbrtj commented Mar 17, 2025 • edited by kibanamachine Loading

elasticmachine commented Mar 17, 2025

peteharverson left a comment

Choose a reason for hiding this comment

darnautov left a comment

Choose a reason for hiding this comment

darnautov Mar 20, 2025

Choose a reason for hiding this comment

rbrtj Mar 21, 2025

Choose a reason for hiding this comment

peteharverson Mar 24, 2025

Choose a reason for hiding this comment

darnautov Mar 20, 2025

Choose a reason for hiding this comment

rbrtj Mar 21, 2025 • edited Loading

Choose a reason for hiding this comment

darnautov Mar 24, 2025

Choose a reason for hiding this comment

peteharverson Mar 24, 2025

Choose a reason for hiding this comment

darnautov left a comment

Choose a reason for hiding this comment

elasticmachine commented Mar 24, 2025

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Public APIs missing exports

History

kibanamachine commented Mar 24, 2025

kibanamachine commented Mar 24, 2025

💔 Some backports could not be created

Manual backport

Questions ?

rbrtj commented Mar 17, 2025 •

edited by kibanamachine

Loading

rbrtj Mar 21, 2025 •

edited

Loading