[unification] Updates to AI Assistant Calls to Action #216105
Merged
+314
−88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clintandrewhall
added
review
release_note:skip
clintandrewhall
requested review from
bojanasan,
julianrosado,
florent-leborgne and
isaclfreire
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
|
Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant) |
clintandrewhall
force-pushed
the
ai/calls-to-action
branch
from
1dd9b98 to
1e74632
Compare
florent-leborgne
approved these changes
Mar 27, 2025
.../ai-assistant/ai-assistant-cta/install_knowledge_base/install_knowledge_base.translations.ts
Outdated
Show resolved
Hide resolved
Dosant
approved these changes
Mar 27, 2025
…install_knowledge_base/install_knowledge_base.translations.ts Co-authored-by: florent-leborgne <[email protected]>
|
Starting backport for target branches: 9.0 |
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
History
|
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 27, 2025
## Summary This PR addresses feedback and includes a number of changes: - allow a CTA to be offset by the height of the `AssistantBeacon` when centered vertically, (e.g. in a tall `FlexItem`). - add `data-test-subj` prop to panels for consumers writing tests. - updates to copy, documentation, tests, storybook. --------- Co-authored-by: florent-leborgne <[email protected]> (cherry picked from commit c4fa63f)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Mar 27, 2025
…#216211) # Backport This will backport the following commits from `main` to `9.0`: - [[unification] Updates to AI Assistant Calls to Action (#216105)](#216105) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Clint Andrew Hall","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-03-27T17:11:57Z","message":"[unification] Updates to AI Assistant Calls to Action (#216105)\n\n## Summary\n\nThis PR addresses feedback and includes a number of changes:\n\n- allow a CTA to be offset by the height of the `AssistantBeacon` when\ncentered vertically, (e.g. in a tall `FlexItem`).\n- add `data-test-subj` prop to panels for consumers writing tests.\n- updates to copy, documentation, tests, storybook.\n\n---------\n\nCo-authored-by: florent-leborgne <[email protected]>","sha":"c4fa63f1213e1a2105f0ab0a773be46cb0ce894c","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["review","release_note:skip","Team:SharedUX","backport:prev-minor","Feature:Security Assistant","Team:Obs AI Assistant","v9.1.0"],"title":"[unification] Updates to AI Assistant Calls to Action","number":216105,"url":"https://github.com/elastic/kibana/pull/216105","mergeCommit":{"message":"[unification] Updates to AI Assistant Calls to Action (#216105)\n\n## Summary\n\nThis PR addresses feedback and includes a number of changes:\n\n- allow a CTA to be offset by the height of the `AssistantBeacon` when\ncentered vertically, (e.g. in a tall `FlexItem`).\n- add `data-test-subj` prop to panels for consumers writing tests.\n- updates to copy, documentation, tests, storybook.\n\n---------\n\nCo-authored-by: florent-leborgne <[email protected]>","sha":"c4fa63f1213e1a2105f0ab0a773be46cb0ce894c"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/216105","number":216105,"mergeCommit":{"message":"[unification] Updates to AI Assistant Calls to Action (#216105)\n\n## Summary\n\nThis PR addresses feedback and includes a number of changes:\n\n- allow a CTA to be offset by the height of the `AssistantBeacon` when\ncentered vertically, (e.g. in a tall `FlexItem`).\n- add `data-test-subj` prop to panels for consumers writing tests.\n- updates to copy, documentation, tests, storybook.\n\n---------\n\nCo-authored-by: florent-leborgne <[email protected]>","sha":"c4fa63f1213e1a2105f0ab0a773be46cb0ce894c"}}]}] BACKPORT--> Co-authored-by: Clint Andrew Hall <[email protected]>
cqliu1
pushed a commit
to cqliu1/kibana
that referenced
this pull request
Mar 31, 2025
## Summary This PR addresses feedback and includes a number of changes: - allow a CTA to be offset by the height of the `AssistantBeacon` when centered vertically, (e.g. in a tall `FlexItem`). - add `data-test-subj` prop to panels for consumers writing tests. - updates to copy, documentation, tests, storybook. --------- Co-authored-by: florent-leborgne <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses feedback and includes a number of changes:
AssistantBeaconwhen centered vertically, (e.g. in a tallFlexItem).data-test-subjprop to panels for consumers writing tests.