Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sync-service): Separate stack telemetry from application telemetry #2337

Merged
merged 13 commits into from
Feb 17, 2025

Conversation

robacourt
Copy link
Contributor

Our cloud version of electric has multiple stacks, one per tenant/database. Since we want metrics from each tenant, this PR separates the stack/tenant specific telemetry from the application/system telemetry. For cloud electric we will then have 1 application metric message and multiple stack metric messages being sent each time we poll.

@robacourt robacourt marked this pull request as ready for review February 13, 2025 13:49
Copy link
Contributor

@msfstef msfstef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't gone over the specifics but the splitting makes sense - LGTM! (tests are not running though)

@robacourt robacourt merged commit 7cb4ccb into main Feb 17, 2025
6 of 9 checks passed
@robacourt robacourt deleted the rob/separate-stack-telemetry branch February 17, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants