Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Respect unpack minimatch for symlinks within previously unpacked directories #341

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

fix: Respect unpack minimatch for symlinks within previously unpacked directories #341

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
2ba954c
fix: Respecting unpack configuration when considering symlinks within…
mmaietta Nov 11, 2024
eb70817
adding test case for windows
mmaietta Nov 12, 2024
803863c
Update cli-spec.js
mmaietta Nov 12, 2024
eae421c
fix test
mmaietta Nov 12, 2024
e5a0eab
Update cli-spec.js
mmaietta Nov 13, 2024
0cd5765
Merge branch 'fix/static-framework-symlinks-2' of https://github.com/…
mmaietta Nov 13, 2024
888ef4f
throw custom error message for windows symlink permission issues
mmaietta Nov 13, 2024
69178e1
fix test
mmaietta Nov 13, 2024
833107f
tmp save
mmaietta Nov 13, 2024
e356f1a
prettier
mmaietta Nov 17, 2024
ce34c6a
tmp save
mmaietta Nov 17, 2024
1676a0e
tmp save
mmaietta Nov 18, 2024
2effa8b
only run symlink test on mac/linux
mmaietta Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update cli-spec.js 
prettier
  • Loading branch information
@mmaietta
mmaietta committed Nov 12, 2024
commit 803863c7aed76697663cf57d51b4558e1afed57a
8 changes: 6 additions & 2 deletions test/cli-spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,8 +233,12 @@ describe('command line interface', function () {
);
assert.ok(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After git cloning on Windows, SymlinkedDir is not a symlink but rather a regular file. I suggest only testing this on macOS/Linux. No need to test on Windows since you're not handling symlink in window.

https://github.com/mmaietta/asar/blob/1676a0ea070967f818167164be5bf7d0e378fb41/src/disk.ts#L65-L68

fs
.realpathSync('tmp/packthis-with-symlink.asar.unpacked/WindowsMklink/SymlinkedDir/test.txt')
.endsWith(path.normalize('tmp/packthis-with-symlink.asar.unpacked/WindowsMklink/Test/test.txt')),
.realpathSync(
'tmp/packthis-with-symlink.asar.unpacked/WindowsMklink/SymlinkedDir/test.txt',
)
.endsWith(
path.normalize('tmp/packthis-with-symlink.asar.unpacked/WindowsMklink/Test/test.txt'),
),
);
}
});
Expand Down