Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ele 3960 adaptive cards #1785

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Ele 3960 adaptive cards #1785

merged 1 commit into from
Jan 27, 2025

Conversation

MikaKerman
Copy link
Contributor

@MikaKerman MikaKerman commented Jan 15, 2025

  • Introduced new adaptive_cards.py module for formatting messages as adaptive cards, including functions for various block types such as headers, lines, facts, and expandable sections.
  • Implemented utility functions to format message blocks and handle different styles and colors.
  • Added comprehensive unit tests for adaptive card formatting, covering various scenarios including headers, icons, text styles, and expandable blocks.
  • Created fixture files for expected JSON outputs to validate the formatting logic.

Copy link

linear bot commented Jan 15, 2025

ELE-3960 adaptive cards

Copy link
Contributor

👋 @MikaKerman
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in this pull request.

@MikaKerman MikaKerman force-pushed the ele-3960-adaptive-cards branch 2 times, most recently from 58541e0 to cca5481 Compare January 16, 2025 15:39
@MikaKerman MikaKerman force-pushed the ele-3960-adaptive-cards branch 2 times, most recently from a6a77e6 to 596b733 Compare January 27, 2025 12:36
@MikaKerman MikaKerman requested a review from ofek1weiss January 27, 2025 12:37
- Introduced new `adaptive_cards.py` module for formatting messages as adaptive cards, including functions for various block types such as headers, lines, facts, and expandable sections.
- Implemented utility functions to format message blocks and handle different styles and colors.
- Added comprehensive unit tests for adaptive card formatting, covering various scenarios including headers, icons, text styles, and expandable blocks.
- Created fixture files for expected JSON outputs to validate the formatting logic.
@MikaKerman MikaKerman force-pushed the ele-3960-adaptive-cards branch from 596b733 to cc614cf Compare January 27, 2025 12:40
@MikaKerman MikaKerman merged commit 9c055a1 into master Jan 27, 2025
4 checks passed
@MikaKerman MikaKerman deleted the ele-3960-adaptive-cards branch January 27, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants