Don't print newline if no failures in fileslist formatter (palantir#1563

) Addresses review #875140 in PR palantir#1558 for compatibility with discussion item palantir#1553
eliasmohsengrenvald · Sep 21, 2016 · 424ce70 · 424ce70
1 parent 5cc19bd
commit 424ce70
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/formatters/fileslistFormatter.ts b/src/formatters/fileslistFormatter.ts
@@ -20,6 +20,10 @@ import {RuleFailure} from "../language/rule/rule";
 
 export class Formatter extends AbstractFormatter {
     public format(failures: RuleFailure[]): string {
+        if (failures.length === 0) {
+            return "";
+        }
+
         const files: string[] = [];
         let currentFile: string;
 

diff --git a/test/formatters/fileslistFormatterTests.ts b/test/formatters/fileslistFormatterTests.ts
@@ -45,6 +45,6 @@ describe("Files-list Formatter", () => {
 
     it("handles no failures", () => {
         const result = formatter.format([]);
-        assert.equal(result, "\n");
+        assert.equal(result, "");
     });
 });