Disable all PlatformHandlerTest_Cookies_Http2 for WinHttpHandler. (do…

…tnet#34119) * Disable all PlatformHandlerTest_Cookies_Http2 for WinHttpHandler. * Added ActiveIssue note. Co-Authored-By: Stephen Toub <[email protected]> Co-authored-by: Stephen Toub <[email protected]>
elinor-fung · Mar 26, 2020 · 02b0f8d · 02b0f8d
1 parent 3b719ca
commit 02b0f8d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.Cookies.cs b/src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.Cookies.cs
@@ -331,12 +331,6 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async url =>
         [MemberData(nameof(CookieNamesValuesAndUseCookies))]
         public async Task GetAsync_ReceiveSetCookieHeader_CookieAdded(string cookieName, string cookieValue, bool useCookies)
         {
-            if (UseVersion.Major == 2)
-            {
-                // [ActiveIssue("https://github.com/dotnet/runtime/issues/33930")]
-                return;
-            }
-
             await LoopbackServerFactory.CreateServerAsync(async (server, url) =>
             {
                 HttpClientHandler handler = CreateHttpClientHandler();

diff --git a/src/libraries/System.Net.Http.WinHttpHandler/tests/FunctionalTests/PlatformHandlerTest.cs b/src/libraries/System.Net.Http.WinHttpHandler/tests/FunctionalTests/PlatformHandlerTest.cs
@@ -193,13 +193,15 @@ public PlatformHandler_HttpClientHandler_Authentication_Test(ITestOutputHelper o
     }
 
 #if NETCOREAPP
+#if !WINHTTPHANDLER_TEST // [ActiveIssue("https://github.com/dotnet/runtime/issues/33930")]
     [ConditionalClass(typeof(PlatformDetection), nameof(PlatformDetection.IsWindows10Version1607OrGreater))]
     public sealed class PlatformHandlerTest_Cookies_Http2 : HttpClientHandlerTest_Cookies
     {
         protected override Version UseVersion => HttpVersion20.Value;
 
         public PlatformHandlerTest_Cookies_Http2(ITestOutputHelper output) : base(output) { }
     }
+#endif
 
     public sealed class PlatformHandler_HttpClientHandler_Asynchrony_Http2_Test : HttpClientHandler_Asynchrony_Test
     {