Skip to content

Commit

Permalink
Avoid macOS prompt to allow incoming connections in liveshare tests
Browse files Browse the repository at this point in the history
Listening on the localhost interface disallows connections from the
outside anyway, so the OS firewall doesn't have to prompt whether the
user wants to allow incoming connections to the Go process.
  • Loading branch information
mislav committed Oct 14, 2021
1 parent 53479c7 commit d68126a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/liveshare/port_forwarder_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ func TestPortForwarderStart(t *testing.T) {
}
defer testServer.Close()

listen, err := net.Listen("tcp", ":8000")
listen, err := net.Listen("tcp", "127.0.0.1:8000")
if err != nil {
t.Fatal(err)
}
Expand Down

0 comments on commit d68126a

Please sign in to comment.