Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update content width for improved accessibility #2048

Closed

Conversation

hichemfantar
Copy link
Contributor

@hichemfantar hichemfantar commented Jan 21, 2025

Adjust the content width variable to enhance the responsiveness of the layout.

w3 recommends 70em which is a nice balance between showing the max amount of content (reduce scrolling) without compromising readability

https://www.w3.org/WAI/tutorials/page-structure/styling/#line-length

before
image

after
image

Copy link

@hichemfantar hichemfantar marked this pull request as ready for review January 21, 2025 01:20
@josevalim
Copy link
Member

The reasoning for 70em according to linked resource is to show 80 characters. Today we are showing 108, which is close to Elixir's formatter line length of 98, but this change extends it with ~20 more chars. I don't believe we should go ahead with it. Thank you.

@josevalim josevalim closed this Jan 21, 2025
@hichemfantar hichemfantar deleted the better-content-max-width branch January 21, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants