Fix error with size-0 array; add -pedantic to compiler options.

-pedantic gives stricter standard compliance on gcc/clang, and would
have catched this error where only VS complained.

engine/Makefile

@@ -55,7 +55,7 @@ endif
 
 MKDIR      = mkdir
 CXX        = g++
-CPP_FLAGS  = -Wall -Wextra -Woverloaded-virtual -W -I. -DSC_SHARED_DATA=\"$(SHARED_DATA)\" --std=c++11 -O3 -MMD -MP
+CPP_FLAGS  = -Wall -Wextra -Woverloaded-virtual -W -I. -DSC_SHARED_DATA=\"$(SHARED_DATA)\" --std=c++11 -O3 -MMD -MP -pedantic
 OPTS       =
 GIT        = $(shell [ -d ../.git ] && which git)
 

engine/class_modules/warlock/sc_warlock.cpp

@@ -159,19 +159,19 @@ namespace warlock
       {
         action_list_str = "shadow_bite";
         owner_coeff.ap_from_sp *= 1.2;
-      };
+      }
 
       void felhunter_pet_t::init_base_stats()
       {
         warlock_pet_t::init_base_stats();
         melee_attack = new warlock_pet_melee_t( this );
-      };
+      }
 
       action_t* felhunter_pet_t::create_action( const std::string& name, const std::string& options_str )
       {
         if ( name == "shadow_bite" ) return new shadow_bite_t( this );
         return warlock_pet_t::create_action( name, options_str );
-      };
+      }
     }
 
     namespace imp

engine/player/sc_enchant.cpp

@@ -18,7 +18,9 @@ namespace /* ANONYMOUS NAMESPACE */
  * applicable. The enchant ID (number) maps to the array of
  * item_enchantment_data_t structs in sc_item_data.inc.
  */
-const enchant_db_item_t __enchant_db[] = {};
+const enchant_db_item_t __enchant_db[] = {
+    { nullptr, 0 } // Dummy entry since we can not have a array with size 0.
+};
 
 size_t enchant_map_key(const dbc_t& dbc, const item_enchantment_data_t& enchant)
 {
@@ -33,6 +35,8 @@ unsigned enchant::find_enchant_id( const std::string& name )
 {
   for ( auto& enchant_entry : __enchant_db )
   {
+    if ( !enchant_entry.enchant_name )
+      continue;
     if ( util::str_compare_ci( enchant_entry.enchant_name, name ) )
       return enchant_entry.enchant_id;
   }
@@ -44,6 +48,8 @@ std::string enchant::find_enchant_name( unsigned enchant_id )
 {
   for ( auto& enchant_entry : __enchant_db )
   {
+    if ( !enchant_entry.enchant_name )
+      continue;
     if ( enchant_entry.enchant_id == enchant_id )
       return enchant_entry.enchant_name;
   }

engine/player/sc_unique_gear_x7.cpp

@@ -2622,7 +2622,7 @@ void item::riftworld_codex( special_effect_t& effect )
   };
 
   new riftworld_codex_callback_t( effect, buffs );
-};
+}
 
 // Toe Knee's Promise ======================================================