Skip to content

Commit

Permalink
Avoid hardcoded type conversion for metadata
Browse files Browse the repository at this point in the history
The engine uses the names `int` and `float` to refer to the 64-bit types, so in the bindings generator we have a hardcoded conversion for those types.

But this type conversion should not be used for metadata. Even though the underlying type should still be 64-bit for interop, metadata is meant to specify the correct type to expose. So if metadata says `float` it means the type is really meant to be a 32-bit `float` and not `double`. Other hardcoded type conversions (`int` and `Nil`) won't ever be metadata.

This change corrects the `float` type, to use the right type in the generated C++ code. Before we were always using `double` due to this type conversion.
  • Loading branch information
raulsntos committed Aug 20, 2024
1 parent fbbf9ec commit 4829199
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions binding_generator.py
Original file line number Diff line number Diff line change
Expand Up @@ -2719,8 +2719,6 @@ def correct_type(type_name, meta=None, use_alias=True):
if meta is not None:
if "int" in meta:
return f"{meta}_t"
elif meta in type_conversion:
return type_conversion[type_name]
else:
return meta
if type_name in type_conversion:
Expand Down

0 comments on commit 4829199

Please sign in to comment.