bpo-37072: Fix crash in PyAST_FromNodeObject() when flags is NULL (py…

…thon#13634) I'm confident that this fixes the reported crash. flags=NULL is treated as using the latest minor version. https://bugs.python.org/issue37072
elprans · May 28, 2019 · 77f0ed7 · 77f0ed7
1 parent 44bfff2
commit 77f0ed7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/Misc/NEWS.d/next/Core and Builtins/2019-05-28-18-18-55.bpo-37072.1Hewl3.rst b/Misc/NEWS.d/next/Core and Builtins/2019-05-28-18-18-55.bpo-37072.1Hewl3.rst
@@ -0,0 +1 @@
+Fix crash in PyAST_FromNodeObject() when flags is NULL.
diff --git a/Python/ast.c b/Python/ast.c
@@ -786,7 +786,7 @@ PyAST_FromNodeObject(const node *n, PyCompilerFlags *flags,
     /* borrowed reference */
     c.c_filename = filename;
     c.c_normalize = NULL;
-    c.c_feature_version = flags->cf_feature_version;
+    c.c_feature_version = flags ? flags->cf_feature_version : PY_MINOR_VERSION;
 
     if (TYPE(n) == encoding_decl)
         n = CHILD(n, 0);
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fix crash in PyAST_FromNodeObject() when flags is NULL.