Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoinstall Widevine updates #202

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dagwieers
Copy link
Collaborator

This adds a feature to enable automatic installation of Widevine.

@dagwieers dagwieers added this to the v0.5.0 milestone Sep 25, 2019
@dagwieers
Copy link
Collaborator Author

dagwieers commented Sep 25, 2019

So, we may want to allow for this only after accepting the EULA once, or maybe as long as the EULA does not change. The idea is to have this when users are not technical savvy and may not continue as expected.

This would fix the situations I have seen where people (or children) did not proceed because they didn't know what to do (and the buttons default to No/Cancel).

Obviously this is more suited for the quick ZIP-based installation, because the ARM progress dialog can easily be interrupted (and may get interrupted because children cannot wait and may not understand the dialog text :-))

@@ -10,6 +10,7 @@
<setting label="30904" type="text" id="warning" enable="false"/> <!-- disabled_warning -->
<setting label="30905" help="30906" type="slider" id="update_frequency" default="31" range="1,3,90" option="int" enable="eq(-2,false)" visible="!system.platform.android"/>
<setting label="30907" help="30908" type="folder" id="temp_path" source="" option="writeable" default="special://masterprofile/addon_data/script.module.inputstreamhelper" visible="!system.platform.android"/>
<setting label="Auto-install Widevine CDM" type="bool" id="automatic_install" default="false"/>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "Unattended Widevine CDM install" is a better description.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed.

@mediaminister
Copy link
Collaborator

mediaminister commented Nov 6, 2019

So, we may want to allow for this only after accepting the EULA once, or maybe as long as the EULA does not change.

I didn't see a Widevine CDM EULA when testing this. This can only be merged if the user accepts the EULA every time this setting is enabled.

@dagwieers
Copy link
Collaborator Author

@mediaminister Correct, I don't think this would be ready to be merged. I wasn't sure if we wanted this really, so I put it out here to discuss.

@dagwieers
Copy link
Collaborator Author

Let me also move the non-related changes out of this PR.

This adds a feature to enable automatic installation of Widevine.
@dagwieers dagwieers changed the title Autoinstall Widevine updates WIP: Autoinstall Widevine updates Nov 6, 2019
@dagwieers dagwieers marked this pull request as draft April 16, 2020 00:45
@dagwieers dagwieers changed the title WIP: Autoinstall Widevine updates Autoinstall Widevine updates Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants