Prevent NUM_SIGS from touching sig_set_

emkey1 · Mar 8, 2020 · cd2cff1 · cd2cff1
1 parent 0e642a0
commit cd2cff1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/fs/tty.c b/fs/tty.c
@@ -364,7 +364,7 @@ ssize_t tty_input(struct tty *tty, const char *input, size_t size, bool blocking
     unlock(&tty->lock);
 
     if (fg_group != 0) {
-        for (int sig = 1; sig <= NUM_SIGS; sig++) {
+        for (int sig = 1; sig < NUM_SIGS; sig++) {
             if (sigset_has(queue, sig))
                 send_group_signal(fg_group, sig, SIGINFO_NIL);
         }

diff --git a/kernel/signal.h b/kernel/signal.h
@@ -145,7 +145,7 @@ dword_t sys_rt_sigprocmask(dword_t how, addr_t set, addr_t oldset, dword_t size)
 int_t sys_rt_sigpending(addr_t set_addr);
 
 static inline sigset_t_ sig_mask(int sig) {
-    assert(sig >= 1 && sig <= NUM_SIGS);
+    assert(sig >= 1 && sig < NUM_SIGS);
     return 1l << (sig - 1);
 }