Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved examples #342

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Improved examples #342

merged 1 commit into from
Jan 29, 2024

Conversation

StefanoIncardone
Copy link
Contributor

@StefanoIncardone StefanoIncardone commented Jan 29, 2024

Improved consistency of examples and moved examples related resources out of the root folder and into the examples folder.
I also wanted to ask what to do with examples that crash (such as with icon.rs on wayland: should we remove them or keep them for the future?

@emoon
Copy link
Owner

emoon commented Jan 29, 2024

As set_icon is a public API we should make sure that it doesn't crash under wayland even if wayland doesn't support setting icons on Windows.

@emoon emoon merged commit 61af248 into emoon:master Jan 29, 2024
4 checks passed
@emoon
Copy link
Owner

emoon commented Jan 29, 2024

Merging this even if the icons example crashes on wayland. Great work once again!

@StefanoIncardone
Copy link
Contributor Author

Merging this even if the icons example crashes on wayland. Great work once again!

There were quite a number of examples that did not work or crashed, due to missing implementation of internal methods, so these examples will "fix themselves" once the required functionalities get implemented

@emoon
Copy link
Owner

emoon commented Jan 30, 2024

Yeah, the problem is that I didn't implement the Wayland backend myself so it has some issues with some missing functionality. It all should be updated to the latest crates, but it requires a bunch of rewrite when doing that and I just haven't got around to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants