MDL-65086 analytics: Deprecate get_enabled_time_splitting_methods

emp7eror · Nov 17, 2020 · a726e52 · a726e52
1 parent d330035
commit a726e52
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/analytics/classes/manager.php b/analytics/classes/manager.php
@@ -300,18 +300,12 @@ public static function get_all_time_splittings() {
     }
 
     /**
-     * Returns the enabled time splitting methods.
-     *
-     * @deprecated since Moodle 3.7
-     * @todo MDL-65086 This will be deleted in Moodle 3.11
-     * @see \core_analytics\manager::get_time_splitting_methods_for_evaluation
-     * @return \core_analytics\local\time_splitting\base[]
+     * @deprecated since Moodle 3.7 use get_time_splitting_methods_for_evaluation instead
      */
     public static function get_enabled_time_splitting_methods() {
-        debugging('This function has been deprecated. You can use self::get_time_splitting_methods_for_evaluation if ' .
+        throw new coding_exception(__FUNCTION__ . '() has been removed. You can use self::get_time_splitting_methods_for_evaluation if ' .
             'you want to get the default time splitting methods for evaluation, or you can use self::get_all_time_splittings if ' .
             'you want to get all the time splitting methods available on this site.');
-        return self::get_time_splitting_methods_for_evaluation();
     }
 
     /**

diff --git a/analytics/upgrade.txt b/analytics/upgrade.txt
@@ -1,6 +1,10 @@
 This files describes API changes in analytics sub system,
 information provided here is intended especially for developers.
 
+=== 3.11 ===
+* Final deprecation get_enabled_time_splitting_methods. Method has been removed. Use
+  get_time_splitting_methods_for_evaluation instead.
+
 === 3.8 ===
 
 * "Time-splitting method" have been replaced by "Analysis interval" for the language strings that are