-
-
Notifications
You must be signed in to change notification settings - Fork 844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nexus] Add changelogTemplate #6426
base: master
Are you sure you want to change the base?
Conversation
@BiNZGi this need a bit more work , older releases are not matching with current template , so we need link: "" for the versions which are lower than 3-59-0 . 3-59-0 and above working |
That's why I separated the PR 😏... First check, found: |
It looks like there is another pattern if a patch version is released, e.g. I think that is possible to do with a special |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯 🥇 🎉
@@ -164,209 +164,239 @@ releases: | |||
eol: 2025-02-15 | |||
latest: "3.59.0-01" | |||
latestReleaseDate: 2023-08-15 | |||
link: https://help.sonatype.com/en/sonatype-nexus-repository-{% assign dashedReleaseCycle = "__RELEASE_CYCLE__.0"|replace:".","-" %}{% assign dashedPatch = "__LATEST__"|replace:".","-"|split:"-"|slice:0,3|join:"-" %}{{ dashedReleaseCycle }}{% if dashedReleaseCycle != dashedPatch %}---{{ dashedPatch }}{% endif %}-release-notes.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
link: https://help.sonatype.com/en/sonatype-nexus-repository-{% assign dashedReleaseCycle = "__RELEASE_CYCLE__.0"|replace:".","-" %}{% assign dashedPatch = "__LATEST__"|replace:".","-"|split:"-"|slice:0,3|join:"-" %}{{ dashedReleaseCycle }}{% if dashedReleaseCycle != dashedPatch %}---{{ dashedPatch }}{% endif %}-release-notes.html | |
link: https://help.sonatype.com/en/sonatype-nexus-repository-3-59-0-release-notes.html |
I would rather directly set the link than using such complicated changelog template: all of the releases using this changelog template are EOL. WDYT ?
From #6424 to add changelogTemplate