Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nexus] Add changelogTemplate #6426

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

[nexus] Add changelogTemplate #6426

wants to merge 9 commits into from

Conversation

BiNZGi
Copy link
Member

@BiNZGi BiNZGi commented Dec 17, 2024

From #6424 to add changelogTemplate

@BiNZGi BiNZGi added the product-updates Product content updates that are not fixes nor releases updates label Dec 17, 2024
@BiNZGi BiNZGi mentioned this pull request Dec 17, 2024
@usta usta changed the title [nexus] Add changelogTemplate [nexusRepo] Add changelogTemplate Dec 17, 2024
@usta
Copy link
Member

usta commented Dec 17, 2024

@BiNZGi this need a bit more work , older releases are not matching with current template , so we need link: "" for the versions which are lower than 3-59-0 . 3-59-0 and above working

@BiNZGi BiNZGi marked this pull request as ready for review February 4, 2025 07:45
Copy link
Member

@usta usta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯 🥇 🎉

@marcwrobel marcwrobel changed the title [nexusRepo] Add changelogTemplate [nexus] Add changelogTemplate Feb 19, 2025
@@ -164,209 +164,239 @@ releases:
eol: 2025-02-15
latest: "3.59.0-01"
latestReleaseDate: 2023-08-15
link: https://help.sonatype.com/en/sonatype-nexus-repository-{% assign dashedReleaseCycle = "__RELEASE_CYCLE__.0"|replace:".","-" %}{% assign dashedPatch = "__LATEST__"|replace:".","-"|split:"-"|slice:0,3|join:"-" %}{{ dashedReleaseCycle }}{% if dashedReleaseCycle != dashedPatch %}---{{ dashedPatch }}{% endif %}-release-notes.html
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
link: https://help.sonatype.com/en/sonatype-nexus-repository-{% assign dashedReleaseCycle = "__RELEASE_CYCLE__.0"|replace:".","-" %}{% assign dashedPatch = "__LATEST__"|replace:".","-"|split:"-"|slice:0,3|join:"-" %}{{ dashedReleaseCycle }}{% if dashedReleaseCycle != dashedPatch %}---{{ dashedPatch }}{% endif %}-release-notes.html
link: https://help.sonatype.com/en/sonatype-nexus-repository-3-59-0-release-notes.html

I would rather directly set the link than using such complicated changelog template: all of the releases using this changelog template are EOL. WDYT ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product-updates Product content updates that are not fixes nor releases updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants