fixed #8 introduced regression bug. We now use /tmp as default tempor…

…ary directory.
ensky · Jan 26, 2021 · 5c7801d · 5c7801d
1 parent b0bdb55
commit 5c7801d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/lib/taiwan-holiday.js b/lib/taiwan-holiday.js
@@ -14,7 +14,7 @@ var TaiwanHoliday = {
 	 */
 	init: function (ctor_conf) {
 		ctor_conf = ctor_conf || {};
-		temp_dir = ctor_conf.temp_dir || env_conf.temp_dir || path.resolve(__dirname, '../data');
+		temp_dir = ctor_conf.temp_dir || env_conf.temp_dir;
 
 		this.cache = new Cache(path.resolve(temp_dir, 'taiwan-holiday-cache.json'));
 		return this.cache.load()
@@ -25,9 +25,11 @@ var TaiwanHoliday = {
 					.then((str) => ret = JSON.parse(str))
 					.then((result) => this.cache.save(result))
 					.then(() => ret);
-			})
-			.then((json) => {
+			}).then((json) => {
 				engine = new OpendataTW(json);
+			}).catch((e) => {
+				console.error(e);
+				throw e;
 			});
 	},
 

diff --git a/package.json b/package.json
@@ -4,8 +4,8 @@
   "description": "let me help you find out it's taiwan holiday or not.",
   "main": "index.js",
   "scripts": {
-	"test": "nyc mocha",
-	"coveralls": "istanbul cover ./node_modules/mocha/bin/_mocha --report lcovonly -- -R spec && cat ./coverage/lcov.info | ./node_modules/coveralls/bin/coveralls.js && rm -rf ./coverage"
+    "test": "nyc mocha",
+    "coveralls": "istanbul cover ./node_modules/mocha/bin/_mocha --report lcovonly -- -R spec && cat ./coverage/lcov.info | ./node_modules/coveralls/bin/coveralls.js && rm -rf ./coverage"
   },
   "repository": {
     "type": "git",
@@ -29,10 +29,10 @@
     "nyc": "^11.4.1"
   },
   "config": {
-    "temp_dir": ""
+    "temp_dir": "/tmp"
   },
   "dependencies": {
     "request": "^2.83.0",
     "request-promise": "^4.2.2"
   }
-}
+}