executor: support Chunk for SetExecutor (pingcap#5397)

enson16855 · Dec 14, 2017 · d209a36 · d209a36
1 parent 81ffef9
commit d209a36
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/executor/builder.go b/executor/builder.go
@@ -312,10 +312,12 @@ func (b *executorBuilder) buildSimple(v *plan.Simple) Executor {
 }
 
 func (b *executorBuilder) buildSet(v *plan.Set) Executor {
-	return &SetExecutor{
+	e := &SetExecutor{
 		baseExecutor: newBaseExecutor(v.Schema(), b.ctx),
 		vars:         v.VarAssigns,
 	}
+	e.supportChk = true
+	return e
 }
 
 func (b *executorBuilder) buildInsert(v *plan.Insert) Executor {

diff --git a/executor/set.go b/executor/set.go
@@ -30,6 +30,7 @@ import (
 	"github.com/pingcap/tidb/terror"
 	"github.com/pingcap/tidb/types"
 	"github.com/pingcap/tidb/util/charset"
+	"github.com/pingcap/tidb/util/chunk"
 	"github.com/pingcap/tidb/util/sqlexec"
 	goctx "golang.org/x/net/context"
 )
@@ -55,6 +56,17 @@ func (e *SetExecutor) Next(goCtx goctx.Context) (Row, error) {
 	return nil, nil
 }
 
+// NextChunk implements the Executor NextChunk interface.
+func (e *SetExecutor) NextChunk(goCtx goctx.Context, chk *chunk.Chunk) error {
+	chk.Reset()
+	if !e.done {
+		e.done = true
+		err := e.executeSet()
+		return errors.Trace(err)
+	}
+	return nil
+}
+
 func (e *SetExecutor) executeSet() error {
 	sessionVars := e.ctx.GetSessionVars()
 	for _, v := range e.vars {