Seeking AI behaviour #18

EtienneDesticourt · 2016-08-10T00:28:40Z

Pretty much done, just need to figure out how to pass eid from movement to seek.

… instance in agents

ephe-meral · 2016-08-10T08:44:46Z

lib/entice/logic/movement.ex

@@ -28,6 +29,9 @@ defmodule Entice.Logic.Movement do
        |> Map.put(Position, new_pos)
        |> Map.put(Movement, new_movement)
      end)
+    {:ok, %MapInstance{map: map, players: _}} = Entity.fetch_attribute(entity, MapInstance)    


Does the player have a map-instance attribute? I thought it was for maps only...

I added it to be able to notify the player's map's agents but I'll remove it now that we're gonna use :entity_change instead.

…posal

ephe-meral · 2016-08-10T16:42:56Z

lib/entice/logic/ai/seek.ex

@@ -22,36 +22,35 @@ defmodule Entice.Logic.Seek do
    def init(entity, %{aggro_distance: aggro_distance, escape_distance: escape_distance}),
    do: {:ok, entity |> put_attribute(%Seek{aggro_distance: aggro_distance, escape_distance: escape_distance})}

-    def init(entity, _args),
+    def init(entity, _args), 


whitespace change - kittens gonna die! :'(

ephe-meral · 2016-08-14T19:02:27Z

lib/entice/logic/movement.ex


    def terminate(_reason, entity),
    do: {:ok, entity |> remove_attribute(Movement)}
+
+    defp start_update_trigger_timer(message, time) do


Is there a need for this check? Otherwise just simply always use Process.send_after for simplicity

I don't know. I copied it from here 20aa29d#diff-366987ce92dde211ad3e5f552c55e0d4R148 and assumed there was some kind of problem with send_after(message, 0). Although looking at it again it seems it might have just been to return nil so the calling function could interpret it as a timer ref so I'll replace it as you said.

In the other case we needed either the nil or the timer to cancel the timer appropriately - here we don't do anything with it, so we can just use the send_after I think :)

ephe-meral · 2016-08-16T10:44:17Z

lib/entice/logic/movement.ex

@@ -8,7 +8,7 @@ defmodule Entice.Logic.Movement do
  Note that velocity is actually a coefficient for the real velocity thats used inside
  the client, but for simplicities sake we used velocity as a name.
  """
-  defstruct goal: %Coord{}, plane: 1, move_type: 9, velocity: 1.0
+  defstruct goal: %Coord{}, plane: 1, move_type: 9, velocity: 1.0, update_self: false, update_delay: 1


I was thinking maybe we can shorten this a bit - for starters, I guess the update interval is static and can be compile with @update_interval 1 (also note the naming... delay sounds like waiting for something, which we don't do)
Second, I think 1ms for the interval is too short, considering that all NPCs are doing it and there will spam the whole map with position updates. I think for clients we have something like a position update every 50ms or so.
Next, maybe we can find a better name for update_self? Something that tells us that this behaviour is automatically recalculating its state?

How about auto_move_update ?

ephe-meral · 2016-09-09T18:40:11Z

@EtienneDesticourt any updates on this?

EtienneDesticourt · 2016-09-11T08:13:58Z

Nope, no time to work on it lately. You can merge if you're good with the current state, the seeking logic is there even though the pathing AI isn't. We could add that in a separate branch.

…ur initialization

Should probably write smarter tests.

ephe-meral

Cool stuff. Keep going

ephe-meral · 2016-10-16T10:25:18Z

lib/entice/logic/ai/seek.ex

+  defstruct target: nil, aggro_distance: 1000, escape_distance: 2000, path: []
+
+  def register(entity),
+  do: Entity.put_behaviour(entity, Seek.Behaviour, [])


What happens with this behaviour if no params is given? Does it even work then?

ephe-meral · 2016-10-16T10:26:52Z

lib/entice/logic/ai/seek.ex

+    do: {:ok, entity |> put_attribute(%Seek{aggro_distance: aggro_distance, escape_distance: escape_distance})}
+
+    def init(entity, _args),
+    do: {:ok, entity |> put_attribute(%Seek{})}


Same as above, no args = what behaviour?

Right I'll add an init that only take an entity

Here I meant: Do we need this case? Is this actually any use without parameters?

ephe-meral · 2016-10-16T10:28:54Z

lib/entice/logic/ai/seek.ex

+    do: {:ok, entity |> put_attribute(%Seek{})}
+
+    #No introspection for npcs ;)
+    def handle_event({:entity_change, %{entity_id: eid}}, %Entity{id: eid} = entity),


I'm not sure we can actually receive our own updates, can you verify?

ephe-meral · 2016-10-16T10:31:40Z

lib/entice/logic/ai/seek.ex

+
+    def handle_event({:entity_change, %{changed: %{Position => %Position{coord: mover_coord}}, entity_id: moving_entity_id}},
+      %Entity{attributes: %{Position => %Position{coord: my_coord},
+                            Movement => _,


Why do we check for Movement here? I mean, if we need it for the behaviour, why not using the deconstructed variable?

ephe-meral · 2016-10-16T10:33:40Z

lib/entice/logic/ai/seek.ex

+  defmodule Behaviour do
+    use Entice.Entity.Behaviour
+
+    def init(entity, %{aggro_distance: aggro_distance, escape_distance: escape_distance}),


We might want to check already here if all the attributes we require being present are actually there...

I'm not sure what you mean by that. We match on aggro_distance and escape_distance, if they're not there we get the default init, no?

No I meant Attributes, as in if the entity has the attributes we need, i.e. Movement etc.

ephe-meral · 2016-10-16T10:38:44Z

lib/entice/logic/ai/seek.ex

+
+      %Path{vertices: new_path} = case success do
+        :ok -> result
+


Formatting this function and the other below would be nice ;)

ephe-meral · 2016-10-16T10:40:43Z

lib/entice/logic/movement.ex


    def init(entity, _args),
    do: {:ok, entity |> put_attribute(%Movement{})}

+    #TODO: Move all this logic to seek


Good idea ;)

ephe-meral · 2016-10-16T10:42:02Z

lib/entice/logic/movement.ex

+                            Seek => %Seek{path: path},
+                            Position => %Position{coord: current_pos}}} = entity) do
+      #Determine next goal
+      {entity, goal} = case Enum.count(path) do


Alternatively we can also simply match on the List like:

[_ | _] -> ... _ -> {entity, goal}

EtienneDesticourt added 4 commits August 8, 2016 13:12

Skeleton

3d72012

Seek logic rework, removed channel callback

e9913c3

Fixed seek logic and added tests, fixed movement update, added ref to…

59fa130

… instance in agents

Minor rename for clarity

3792cbd

ephe-meral reviewed Aug 10, 2016
View reviewed changes

EtienneDesticourt added 6 commits August 10, 2016 17:25

Modified Seek to listen for :entity_change on Position

1fd1a23

:pos -> :coord

239f2cc

Modified way AI behaviours are chosen for an npc

165397c

Removed added whitespace

f382506

Merge remote-tracking branch 'refs/remotes/origin/master' into AI_Pro…

e9c9693

…posal

:pos -> :coord

6fdee5b

ephe-meral reviewed Aug 10, 2016
View reviewed changes

EtienneDesticourt added 2 commits August 11, 2016 18:55

Whitespace removal

f15a24f

Added auto pos update skeleton

b2a2252

ephe-meral reviewed Aug 14, 2016
View reviewed changes

EtienneDesticourt added 2 commits August 15, 2016 16:23

Cleaned up seeking handler, fixed movement update handler

12af7b6

Removed excess linebreak

260666f

ephe-meral reviewed Aug 16, 2016
View reviewed changes

Naming changes

f718ddf

EtienneDesticourt added 3 commits October 11, 2016 00:22

Updated deps

38b65ca

Put better default aggro/escape dist

f819c1d

Set seeking as default npc behaviour, started auto updates at behavio…

f7ab019

…ur initialization

EtienneDesticourt added 3 commits October 11, 2016 00:45

Fixed tests

0c18581

Should probably write smarter tests.

Changed event from map to atom, fixed seeks option

d93eeb8

Added geom deps, replaced Coord with Vector2D, added NavMesh to maps

e6dc0a6

ephe-meral requested changes Oct 16, 2016

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Seeking AI behaviour #18

Seeking AI behaviour #18

EtienneDesticourt commented Aug 10, 2016

ephe-meral Aug 10, 2016

EtienneDesticourt Aug 10, 2016

ephe-meral Aug 10, 2016

ephe-meral Aug 14, 2016

EtienneDesticourt Aug 15, 2016 •

edited

Loading

ephe-meral Aug 15, 2016

ephe-meral Aug 16, 2016

EtienneDesticourt Aug 16, 2016

ephe-meral commented Sep 9, 2016

EtienneDesticourt commented Sep 11, 2016

ephe-meral left a comment

ephe-meral Oct 16, 2016

ephe-meral Oct 16, 2016

EtienneDesticourt Oct 25, 2016

ephe-meral Oct 25, 2016

ephe-meral Oct 16, 2016

ephe-meral Oct 16, 2016

ephe-meral Oct 16, 2016

EtienneDesticourt Oct 25, 2016

ephe-meral Oct 25, 2016

ephe-meral Oct 16, 2016

ephe-meral Oct 16, 2016

ephe-meral Oct 16, 2016

Seeking AI behaviour #18

Are you sure you want to change the base?

Seeking AI behaviour #18

Conversation

EtienneDesticourt commented Aug 10, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

EtienneDesticourt Aug 15, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ephe-meral commented Sep 9, 2016

EtienneDesticourt commented Sep 11, 2016

ephe-meral left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

EtienneDesticourt Aug 15, 2016 •

edited

Loading