feat: print diff on config change #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leseb
force-pushed
the
config-change-diff
branch
from
af0b0b1 to
4fc4d10
Compare
mathetake
reviewed
Jan 28, 2025
mathetake
reviewed
Jan 28, 2025
When the configuration file is updated, the logger will print the updated sections at the DEBUG level. The implementation is straightforward and does not rely on any external libraries, making it particularly useful for troubleshooting. Output: ``` time=2025-01-28T11:46:03.911+01:00 level=INFO msg="loading a new config" path=docs/extproc-config.yaml time=2025-01-28T11:46:03.911+01:00 level=DEBUG msg="config line changed" line=14 path=docs/extproc-config.yaml old="weight: 1" new="weight: 0" ``` Signed-off-by: Sébastien Han <[email protected]>
leseb
force-pushed
the
config-change-diff
branch
from
4fc4d10 to
bd9a408
Compare
mathetake
reviewed
Jan 28, 2025
mathetake
reviewed
Jan 28, 2025
|
@leseb could you not force-push as per CONTRIBUTING.md? |
mathetake
reviewed
Jan 28, 2025
|
also, could you modify the PR description so that it follows the template |
Signed-off-by: Sébastien Han <[email protected]>
leseb
force-pushed
the
config-change-diff
branch
from
dbee65d to
827bf4b
Compare
|
I had to do another force-push on the second commit since DCO was complaining... |
Thanks! So when CI is green I'll amend it to have a single final commit and force-push, is that alright? |
|
well, all PRs will be squash-merged, so you don't need to do that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message:
feat: print diff on config change
When the configuration file is updated, the logger will print the
updated sections at the DEBUG level. The implementation is
straightforward and does not rely on any external libraries, making it
particularly useful for troubleshooting.
Output:
Signed-off-by: Sébastien Han [email protected]
Related Issues/PRs (if applicable):
Special notes for reviewers (if applicable):