Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: deletes doctests #222

Merged
merged 2 commits into from
Jan 29, 2025
Merged

ci: deletes doctests #222

merged 2 commits into from
Jan 29, 2025

Conversation

mathetake
Copy link
Member

Commit Message:

This deletes the doc test as it turns out that simply
using a markdown parser seems difficult to makintain.
As discussed offline, we decided to remove it for now.
If any necessity comes up in the future, we revisit this
and reevaluate what is the best way to ensure the
correctness of the documentations with code blocks.

Signed-off-by: Takeshi Yoneda <[email protected]>
@mathetake mathetake marked this pull request as ready for review January 29, 2025 20:10
@mathetake mathetake requested a review from a team as a code owner January 29, 2025 20:10
Copy link
Contributor

@missBerg missBerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! lgmt!

@missBerg
Copy link
Contributor

We can think about ways to test docs instructions in the future :)

@mathetake mathetake enabled auto-merge (squash) January 29, 2025 20:14
Signed-off-by: Takeshi Yoneda <[email protected]>
@mathetake mathetake merged commit dbd116c into main Jan 29, 2025
14 checks passed
@mathetake mathetake deleted the deletedoctest branch January 29, 2025 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants