-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix code block indentation #223
Conversation
main branch is currently hosted at https://envoy-ai-gateway.netlify.app/ and will be hosted at aigateway.envoyproxy.io fwiw |
41149ed
to
ba01803
Compare
could you fix the PR title? then good to go |
@mathetake let me check, the preview - seems we may be getting some odd edits |
I don't necessarily a fan of the auto incrementing lists, I understand the benefits, but not a merge blocker. |
I updated the title to match the required format |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok to merge
Head branch was pushed to by a user without write access
3. Download configuration template | ||
|
||
```shell | ||
curl -O https://raw.githubusercontent.com/envoyproxy/ai-gateway/main/examples/basic/basic.yaml | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the important change
|
||
```shell | ||
kubectl logs services/ai-eg-route-extproc-envoy-ai-gateway-basic | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the important change
Block should be indented. Some unrelated minor Markdown formatting improvements like using auto-incrementing lists and removing unnecessary colons. Signed-off-by: David Xia <[email protected]>
Thanks for reviewing. I think I addressed all the comments. |
Commit Message:
Block should be indented.
Some unrelated minor Markdown formatting improvements like using auto-incrementing lists and removing unnecessary colons.