Nan::ReturnValue.Set() needs no Nan::New on primitive types

For bool, double, [u]int32_t there is no need to wrap a returned value in Nan::New() https://github.com/nodejs/nan/blob/master/doc/methods.md#api_nan_return_value
eoneill · Aug 9, 2015 · acd67bf · acd67bf
1 parent d96ad37
commit acd67bf
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/src/binding.cpp b/src/binding.cpp
@@ -262,7 +262,7 @@ NAN_METHOD(render_sync) {
 
   sass_free_context_wrapper(ctx_w);
 
-  info.GetReturnValue().Set(Nan::New<v8::Boolean>(result == 0));
+  info.GetReturnValue().Set(result == 0);
 }
 
 NAN_METHOD(render_file) {
@@ -297,7 +297,7 @@ NAN_METHOD(render_file_sync) {
   free(input_path);
   sass_free_context_wrapper(ctx_w);
 
-  info.GetReturnValue().Set(Nan::New<v8::Boolean>(result == 0));
+  info.GetReturnValue().Set(result == 0);
 }
 
 NAN_METHOD(libsass_version) {

diff --git a/src/sass_types/color.cpp b/src/sass_types/color.cpp
@@ -62,19 +62,19 @@ namespace SassTypes
   }
 
   NAN_METHOD(Color::GetR) {
-    info.GetReturnValue().Set(Nan::New(sass_color_get_r(unwrap(info.This())->value)));
+    info.GetReturnValue().Set(sass_color_get_r(unwrap(info.This())->value));
   }
 
   NAN_METHOD(Color::GetG) {
-    info.GetReturnValue().Set(Nan::New(sass_color_get_g(unwrap(info.This())->value)));
+    info.GetReturnValue().Set(sass_color_get_g(unwrap(info.This())->value));
   }
 
   NAN_METHOD(Color::GetB) {
-    info.GetReturnValue().Set(Nan::New(sass_color_get_b(unwrap(info.This())->value)));
+    info.GetReturnValue().Set(sass_color_get_b(unwrap(info.This())->value));
   }
 
   NAN_METHOD(Color::GetA) {
-    info.GetReturnValue().Set(Nan::New(sass_color_get_a(unwrap(info.This())->value)));
+    info.GetReturnValue().Set(sass_color_get_a(unwrap(info.This())->value));
   }
 
   NAN_METHOD(Color::SetR) {

diff --git a/src/sass_types/list.cpp b/src/sass_types/list.cpp
@@ -76,7 +76,7 @@ namespace SassTypes
   }
 
   NAN_METHOD(List::GetSeparator) {
-    info.GetReturnValue().Set(Nan::New(sass_list_get_separator(unwrap(info.This())->value) == SASS_COMMA));
+    info.GetReturnValue().Set(sass_list_get_separator(unwrap(info.This())->value) == SASS_COMMA);
   }
 
   NAN_METHOD(List::SetSeparator) {