#6215 – Introducing the snap to angle and standard bond length for monomers connected via bonds #6570
+686
−91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-assign
bot
requested review from
NataliaLoginova,
rrodionov91 and
Zhirnoff
svvald
changed the title
rrodionov91
approved these changes
Feb 28, 2025
| snapPosition, | ||
| ).length(); | ||
|
|
||
| if (distanceToSnapPosition < 0.375) { |
There was a problem hiding this comment.
Maybe move 0.375 to constant and use here and I remember the same somewhere in curved bonds
| SelectRectangle.calculateAngleSnap( | ||
| cursorPositionInAngstroms, | ||
| connectedMonomer.position, | ||
| this.editor.mode.modeName === 'snake-layout-mode' ? 90 : 30, |
There was a problem hiding this comment.
Maybe use this.editor.mode instanceof SnakeMode?
Comment on lines
+372
to
+378
| if (isAngleSnapped && isDistanceSnapped) { | ||
| snapPosition = distanceSnapPosition; | ||
| } else if (isAngleSnapped) { | ||
| snapPosition = angleSnapPosition; | ||
| } else if (isDistanceSnapped) { | ||
| snapPosition = distanceSnapPosition; | ||
| } |
There was a problem hiding this comment.
Very clear what happens in this method. Thank you
Comment on lines
+112
to
+113
| this.topLayer.selectAll('*').remove(); | ||
| this.defaultLayer.selectAll('*').remove(); |
There was a problem hiding this comment.
Not sure how * selector works for d3, but potentially it could be a cause of performance degradation in some cases. Let's just keep it in mind for now.
There was a problem hiding this comment.
Maybe it would be better to organize elements somehow to delete only group element
svvald
force-pushed
the
6215-introducing-the-snap-to-angle-and-standard-bond-length-for-monomers-connected-via-bonds
branch
from
c5dc1b6 to
885f752
Compare
svvald
force-pushed
the
6215-introducing-the-snap-to-angle-and-standard-bond-length-for-monomers-connected-via-bonds
branch
from
885f752 to
250b9f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How the feature works? / How did you fix the issue?
(Screenshots, videos, or GIFs, if applicable)
Check list
#1234 – issue name