Add option to ignore models during solving #215
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding option
--ignore-models
, and relevant support for it in the unrolling solver.Description (through Stainless):
As expected, models cannot be checked if we do not ask the solver for them in the first place. Since
feeling-lucky
also uses models during the proof-checking phase in unrolling, it is also explicitly bypassed. The same models are also used for guiding further unrolling by discovering paths to prioritize, and thus this guidance is also bypassed here while the option is turned on.With the option on, counterexamples are replaced by
(Empty Model)
. Example on a bolts example changed to be broken:Functionality should be complete now. I have noticed no change to a slight improvement on smaller examples from
bolts/algorithms
, and I am continuing to do a more comprehensive check.I am trying to see what would be reasonable tests to have for this option. Will request merging after that.
Feel free to check and comment on this!