Mention invalid package name in error message (conda#11601)

eplanner · Jul 7, 2022 · 86447b6 · 86447b6
1 parent 204c86a
commit 86447b6
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 2 deletions.
diff --git a/conda_env/specs/binstar.py b/conda_env/specs/binstar.py
@@ -64,7 +64,7 @@ def valid_name(self):
         elif self.name is None:
             self.msg = "Can't process without a name"
         else:
-            self.msg = "Invalid name, try the format: user/package"
+            self.msg = f"Invalid name {self.name!r}, try the format: user/package"
         return False
 
     def valid_package(self):

diff --git a/news/11601-mention-invalid-name-in-error-message b/news/11601-mention-invalid-name-in-error-message
@@ -0,0 +1,19 @@
+### Enhancements
+
+* Include the invalid package name in the error message. (#11601)
+
+### Bug fixes
+
+* <news item>
+
+### Deprecations
+
+* <news item>
+
+### Docs
+
+* <news item>
+
+### Other
+
+* <news item>
diff --git a/tests/conda_env/specs/test_binstar.py b/tests/conda_env/specs/test_binstar.py
@@ -30,7 +30,7 @@ def test_name_not_present(self):
     def test_invalid_name(self):
         spec = BinstarSpec(name='invalid-name')
         self.assertEqual(spec.can_handle(), False)
-        self.assertEqual(spec.msg, "Invalid name, try the format: user/package")
+        self.assertEqual(spec.msg, "Invalid name 'invalid-name', try the format: user/package")
 
     def test_package_not_exist(self):
         with patch('conda_env.specs.binstar.get_binstar') as get_binstar_mock: