Throw proper exception when required package is not installed

eq123456 · Mar 3, 2019 · 7a3a2e3 · 7a3a2e3
1 parent 108da92
commit 7a3a2e3
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/composer.json b/composer.json
@@ -24,6 +24,9 @@
     "require-dev": {
         "phpunit/phpunit": "^5.7|^6.0"
     },
+    "suggest": {
+        "symfony/http-foundation": "Install if you want to use QrCodeResponse"
+    },
     "autoload": {
         "psr-4": {
             "Endroid\\QrCode\\": "src/"

diff --git a/src/Response/QrCodeResponse.php b/src/Response/QrCodeResponse.php
@@ -14,6 +14,10 @@
 use Endroid\QrCode\QrCodeInterface;
 use Symfony\Component\HttpFoundation\Response;
 
+if (class_exists(Response::class)) {
+    throw new \Exception('QrCodeResponse requires symfony/http-foundation');
+}
+
 class QrCodeResponse extends Response
 {
     public function __construct(QrCodeInterface $qrCode)

diff --git a/tests/QrCodeTest.php b/tests/QrCodeTest.php
@@ -83,7 +83,7 @@ public function writerNamesProvider()
             ['debug', null],
             ['eps', null],
             ['png', 'data:image/png;base64'],
-            ['svg', 'data:image/svg+xml;base64']
+            ['svg', 'data:image/svg+xml;base64'],
         ];
     }
 
@@ -113,7 +113,7 @@ public function extensionsProvider()
             ['txt', null],
             ['eps', null],
             ['png', 'data:image/png;base64'],
-            ['svg', 'data:image/svg+xml;base64']
+            ['svg', 'data:image/svg+xml;base64'],
         ];
     }