Skip to content

Commit

Permalink
mate-base/mate-settings-daemon: depend on min mate-desktop matching $…
Browse files Browse the repository at this point in the history
…{PV}

Depend on >=mate-desktop-$(ver_cut 1-2) to avoid build failures for now
as a quick workaround.

The maintainers should check whether each package really needs it and
also consider a possible QA check in the eclass given some of them
seem to have a pattern in configure.ac for this, but given the bug has
been open for a whlie, I'd rather have some of the deps be unnecessarily
tight (not that it's even that tight) than as-it-was.

Note that couldn't use ${MATE_BRANCH} as it says:
> # Major and minor numbers of the version number, unless live.
> # If live ebuild, will be set to '9999'.
which made me wonder if it's actually meant to be 1-2 or 1-3 in ver_cut
or what.

Anyway, in summary:
* Apply a fix which makes things better, even if it's slightly overkill;
* Someone needs to audit these to find the actual minimum versions
  (some truly do need this, some need just something older, although
  unclear if upstream carefully update these or ont);
* A QA check may be wise.

Bug: https://bugs.gentoo.org/935279
Bug: https://bugs.gentoo.org/936079
Signed-off-by: Sam James <[email protected]>
  • Loading branch information
thesamesam committed Oct 6, 2024
1 parent 5a699b0 commit 6fcd244
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ COMMON_DEPEND=">=dev-util/gdbus-codegen-2.76.4
>=dev-libs/glib-2.50:2
>=gnome-base/dconf-0.13.4
>=mate-base/libmatekbd-1.17.0
>=mate-base/mate-desktop-1.27.1
>=mate-base/mate-desktop-$(ver_cut 1-2)
media-libs/fontconfig:1.0
x11-libs/cairo
x11-libs/gdk-pixbuf:2
Expand Down

0 comments on commit 6fcd244

Please sign in to comment.