fix: Presto column_type_mappings time and timestamp (apache#12861)

* Fix presto column_type_mappings time and timestamp * Added unit tests
eran-levy · Feb 1, 2021 · 51195af · 51195af
1 parent 783aae1
commit 51195af
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/superset/db_engine_specs/presto.py b/superset/db_engine_specs/presto.py
@@ -353,8 +353,8 @@ def _show_columns(
         (re.compile(r"^varbinary.*", re.IGNORECASE), types.VARBINARY()),
         (re.compile(r"^json.*", re.IGNORECASE), types.JSON()),
         (re.compile(r"^date.*", re.IGNORECASE), types.DATE()),
-        (re.compile(r"^time.*", re.IGNORECASE), types.Time()),
         (re.compile(r"^timestamp.*", re.IGNORECASE), types.TIMESTAMP()),
+        (re.compile(r"^time.*", re.IGNORECASE), types.Time()),
         (re.compile(r"^interval.*", re.IGNORECASE), Interval()),
         (re.compile(r"^array.*", re.IGNORECASE), Array()),
         (re.compile(r"^map.*", re.IGNORECASE), Map()),

diff --git a/tests/db_engine_specs/presto_tests.py b/tests/db_engine_specs/presto_tests.py
@@ -554,6 +554,12 @@ def test_get_sqla_column_type(self):
         sqla_type = PrestoEngineSpec.get_sqla_column_type("integer")
         assert isinstance(sqla_type, types.Integer)
 
+        sqla_type = PrestoEngineSpec.get_sqla_column_type("time")
+        assert isinstance(sqla_type, types.Time)
+
+        sqla_type = PrestoEngineSpec.get_sqla_column_type("timestamp")
+        assert isinstance(sqla_type, types.TIMESTAMP)
+
         sqla_type = PrestoEngineSpec.get_sqla_column_type(None)
         assert sqla_type is None