Pack Attack zone #73
Merged
Pack Attack zone #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…events if Packmaster isn't loaded
…and apply card preview effects to cards in shops
erasels
requested changes
Jan 10, 2024
src/main/java/spireMapOverhaul/zones/packattack/PackAttackZone.java
Outdated
Show resolved
Hide resolved
| this.hpLoss = AbstractDungeon.ascensionLevel >= 15 ? A15_HP_LOSS : HP_LOSS; | ||
| this.boosterBox = RelicLibrary.getRelic("anniv5:PMBoosterBox").makeCopy(); | ||
| this.vexed = CardLibrary.getCard("anniv5:Vexed").makeCopy(); | ||
| this.cardistry = CardLibrary.getCard("anniv5:Cardistry").makeCopy(); |
There was a problem hiding this comment.
Using string literals for Ids, smh 😝
| } | ||
|
|
||
| if (!Loader.isModLoaded("anniv5")) { | ||
| throw new RuntimeException("This event requires Packmaster to be loaded"); |
There was a problem hiding this comment.
Hmm, not sure if this is a good idea. If some mod does something weird with a dynamic way to get all events they might run into this accidentally.
Could we just set the only dialogue option to leave if that's the case instead?
There was a problem hiding this comment.
Good suggestion, that will be easy to do.
|
Changes made. Leaving this for you to merge so you can take a quick look over the changes and confirm they match your expectations. |
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I felt this project needed a Packmaster tribute zone, so I made one. I was originally planning to stop at two zones (and don't plan to make more after this), but having a Packmaster tribute was important to me.
This zone picks three packs, and card rewards and shop cards are taken from the zone's packs. In combat, you get a random card from those packs added to your hand each turn, in return for drawing one less card (I didn't want it to be purely positive). If this feels too limiting, it could be two random cards instead.
This remaining content is the zone is two events that are broadly positive and intended to draw people towards the zone. If you get an event while in the zone, it will always be one of these events.
Pack Shrine lets you either pick 1 out of 20 of any Packmaster cards (Library-style events always offer interesting choices) or remove a card by offering it to the shrine in return for gold based on the card's rarity (think Bonfire Spirits, except gold instead of healing and max HP). Like all shrines, this is a purely positive event. It has image variants for both Packmaster and Packmistress.
Black Market Two has three options: PM Booster Box in return for the Vexed curse, three random cards from the zone's packs in return for losing a small amount of HP, or Cardistry in return for some gold. These have costs, but are all intended to be good options. PM Booster Box is strong enough to be worth a curse, three random cards will often be good (but may depend on the zone's packs), and Cardistry is worth buying for most decks. The image is a flipped and slightly modified version of the Packmaster event.
Everything is achieved by reflection so that this doesn't require any dependencies. The zone can only spawn if Packmaster is loaded, and I've tested that it doesn't break when Packmaster isn't loaded. Packmaster's pack filtering is respected.
Most of the code here is for the events and getting pack/card information from Packmaster by reflection. The rest of the zone setup is straightforward.
Here are screenshots for the start of each event:
