forked from ruesandora/celestia-node-TR
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fraud: Define Bad Encoding Fraud Poof struct. Provide functionality f…
…or befp creation/validation. (celestiaorg#545) * feat(fraud): implement BEFP data structure * feat(fraud): add Proto message * feat(fraud): add BEFP creation * feat(fraud): add BEFP validation
- Loading branch information
Showing
15 changed files
with
1,789 additions
and
41 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,154 @@ | ||
| package fraud | ||
|
|
||
| import ( | ||
| "bytes" | ||
| "errors" | ||
| "fmt" | ||
|
|
||
| "github.com/tendermint/tendermint/pkg/consts" | ||
| "github.com/tendermint/tendermint/pkg/wrapper" | ||
|
|
||
| "github.com/celestiaorg/rsmt2d" | ||
|
|
||
| pb "github.com/celestiaorg/celestia-node/fraud/pb" | ||
| "github.com/celestiaorg/celestia-node/ipld" | ||
| ipld_pb "github.com/celestiaorg/celestia-node/ipld/pb" | ||
| "github.com/celestiaorg/celestia-node/service/header" | ||
| ) | ||
|
|
||
| type BadEncodingProof struct { | ||
| BlockHeight uint64 | ||
| // ShareWithProof contains all shares from row or col. | ||
| // Shares that did not pass verification in rmst2d will be nil. | ||
| // For non-nil shares MerkleProofs are computed. | ||
| Shares []*ipld.NamespacedShareWithProof | ||
| // Index represents the row/col index where ErrByzantineRow/ErrByzantineColl occurred | ||
| Index uint8 | ||
| // isRow shows that verification failed on row | ||
| isRow bool | ||
| } | ||
|
|
||
| // CreateBadEncodingProof creates a new Bad Encoding Fraud Proof that should be propagated through network | ||
| // The fraud proof will contain shares that did not pass verification and their relevant Merkle proofs. | ||
| func CreateBadEncodingProof( | ||
| height uint64, | ||
| errByzantine *ipld.ErrByzantine, | ||
| ) Proof { | ||
|
|
||
| return &BadEncodingProof{ | ||
| BlockHeight: height, | ||
| Shares: errByzantine.Shares, | ||
| isRow: errByzantine.IsRow, | ||
| Index: errByzantine.Index, | ||
| } | ||
| } | ||
|
|
||
| // Type returns type of fraud proof | ||
| func (p *BadEncodingProof) Type() ProofType { | ||
| return BadEncoding | ||
| } | ||
|
|
||
| // Height returns block height | ||
| func (p *BadEncodingProof) Height() uint64 { | ||
| return p.BlockHeight | ||
| } | ||
|
|
||
| // MarshalBinary converts BadEncodingProof to binary | ||
| func (p *BadEncodingProof) MarshalBinary() ([]byte, error) { | ||
| shares := make([]*ipld_pb.Share, 0, len(p.Shares)) | ||
| for _, share := range p.Shares { | ||
| shares = append(shares, share.ShareWithProofToProto()) | ||
| } | ||
|
|
||
| badEncodingFraudProof := pb.BadEncoding{ | ||
| Height: p.BlockHeight, | ||
| Shares: shares, | ||
| Index: uint32(p.Index), | ||
| IsRow: p.isRow, | ||
| } | ||
| return badEncodingFraudProof.Marshal() | ||
| } | ||
|
|
||
| // UnmarshalBinary converts binary to BadEncodingProof | ||
| func (p *BadEncodingProof) UnmarshalBinary(data []byte) error { | ||
| in := pb.BadEncoding{} | ||
| if err := in.Unmarshal(data); err != nil { | ||
| return err | ||
| } | ||
| befp := &BadEncodingProof{ | ||
| BlockHeight: in.Height, | ||
| Shares: ipld.ProtoToShare(in.Shares), | ||
| } | ||
|
|
||
| *p = *befp | ||
|
|
||
| return nil | ||
| } | ||
|
|
||
| // Validate ensures that fraud proof is correct. | ||
| // Validate checks that provided Merkle Proofs correspond to the shares, | ||
| // rebuilds bad row or col from received shares, computes Merkle Root | ||
| // and compares it with block's Merkle Root. | ||
| func (p *BadEncodingProof) Validate(header *header.ExtendedHeader) error { | ||
| if header.Height != int64(p.BlockHeight) { | ||
| return errors.New("invalid fraud proof: incorrect block height") | ||
| } | ||
| merkleRowRoots := header.DAH.RowsRoots | ||
| merkleColRoots := header.DAH.ColumnRoots | ||
| if len(merkleRowRoots) != len(merkleColRoots) { | ||
| // NOTE: This should never happen as callers of this method should not feed it with a | ||
| // malformed extended header. | ||
| panic(fmt.Sprintf("invalid extended header: length of row and column roots do not match. (rowRoots=%d) (colRoots=%d)", | ||
| len(merkleRowRoots), | ||
| len(merkleColRoots)), | ||
| ) | ||
| } | ||
| if int(p.Index) >= len(merkleRowRoots) { | ||
| return fmt.Errorf("invalid fraud proof: index out of bounds (%d >= %d)", int(p.Index), len(merkleRowRoots)) | ||
| } | ||
| if len(merkleRowRoots) != len(p.Shares) { | ||
| return fmt.Errorf("invalid fraud proof: incorrect number of shares %d != %d", len(p.Shares), len(merkleRowRoots)) | ||
| } | ||
|
|
||
| root := merkleRowRoots[p.Index] | ||
| if !p.isRow { | ||
| root = merkleColRoots[p.Index] | ||
| } | ||
|
|
||
| shares := make([][]byte, len(merkleRowRoots)) | ||
|
|
||
| // verify that Merkle proofs correspond to particular shares | ||
| for index, share := range p.Shares { | ||
| if share == nil { | ||
| continue | ||
| } | ||
| shares[index] = share.Share | ||
| if ok := share.Validate(root); !ok { | ||
| return fmt.Errorf("invalid fraud proof: incorrect share received at Index %d", index) | ||
| } | ||
| } | ||
|
|
||
| codec := consts.DefaultCodec() | ||
| // rebuild a row or col | ||
| rebuiltShares, err := codec.Decode(shares) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| rebuiltExtendedShares, err := codec.Encode(rebuiltShares[0 : len(shares)/2]) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| rebuiltShares = append(rebuiltShares, rebuiltExtendedShares...) | ||
|
|
||
| tree := wrapper.NewErasuredNamespacedMerkleTree(uint64(len(shares) / 2)) | ||
| for i, share := range rebuiltShares { | ||
| tree.Push(share, rsmt2d.SquareIndex{Axis: uint(p.Index), Cell: uint(i)}) | ||
| } | ||
|
|
||
| // comparing rebuilt Merkle Root of bad row/col with respective Merkle Root of row/col from block | ||
| if bytes.Equal(tree.Root(), root) { | ||
| return errors.New("invalid fraud proof: recomputed Merkle root matches the header's row/column root") | ||
| } | ||
|
|
||
| return nil | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| package fraud | ||
|
|
||
| import ( | ||
| "context" | ||
| "errors" | ||
| "testing" | ||
|
|
||
| format "github.com/ipfs/go-ipld-format" | ||
| mdutils "github.com/ipfs/go-merkledag/test" | ||
| "github.com/stretchr/testify/require" | ||
| "github.com/tendermint/tendermint/pkg/consts" | ||
| "github.com/tendermint/tendermint/pkg/da" | ||
| "github.com/tendermint/tendermint/pkg/wrapper" | ||
|
|
||
| "github.com/celestiaorg/celestia-node/ipld" | ||
| "github.com/celestiaorg/celestia-node/service/header" | ||
| "github.com/celestiaorg/nmt" | ||
| "github.com/celestiaorg/rsmt2d" | ||
| ) | ||
|
|
||
| func TestFraudProofValidation(t *testing.T) { | ||
| dag := mdutils.Mock() | ||
| eds := ipld.RandEDS(t, 2) | ||
| size := eds.Width() | ||
|
|
||
| shares := ipld.ExtractEDS(eds) | ||
| copy(shares[3][8:], shares[4][8:]) | ||
| batchAdder := ipld.NewNmtNodeAdder( | ||
| context.Background(), | ||
| format.NewBatch(context.Background(), dag, format.MaxSizeBatchOption(int(size)*2)), | ||
| ) | ||
| tree := wrapper.NewErasuredNamespacedMerkleTree(uint64(size/2), nmt.NodeVisitor(batchAdder.Visit)) | ||
| attackerEDS, _ := rsmt2d.ImportExtendedDataSquare(shares, consts.DefaultCodec(), tree.Constructor) | ||
| err := batchAdder.Commit() | ||
| require.NoError(t, err) | ||
|
|
||
| da := da.NewDataAvailabilityHeader(attackerEDS) | ||
| r := ipld.NewRetriever(dag, consts.DefaultCodec()) | ||
| _, err = r.Retrieve(context.Background(), &da) | ||
| var errByz *ipld.ErrByzantine | ||
| require.True(t, errors.As(err, &errByz)) | ||
|
|
||
| dah := &header.ExtendedHeader{DAH: &da} | ||
|
|
||
| p := CreateBadEncodingProof(uint64(dah.Height), errByz) | ||
| err = p.Validate(dah) | ||
| require.NoError(t, err) | ||
| } |
Oops, something went wrong.