Skip to content

Commit

Permalink
Bump golang to 1.16
Browse files Browse the repository at this point in the history
  • Loading branch information
bobbypage committed Mar 3, 2021
1 parent 4cf47a7 commit 05a1cd9
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 52 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
- name: Install Go
uses: actions/setup-go@v1
with:
go-version: 1.15
go-version: 1.16
- name: Install golangci-lint
run: >
cd /tmp &&
Expand All @@ -33,7 +33,7 @@ jobs:
test:
strategy:
matrix:
go-versions: [1.15, 1.14]
go-versions: [1.16, 1.15]
platform: [ubuntu-20.04]
environment-variables: [build/config/plain.sh, build/config/libpfm4.sh, build/config/libipmctl.sh]
runs-on: ${{ matrix.platform }}
Expand All @@ -54,7 +54,7 @@ jobs:
test-integration:
strategy:
matrix:
go-versions: [1.15, 1.14]
go-versions: [1.16, 1.15]
platform: [ubuntu-20.04]
environment-variables: [build/config/plain.sh, build/config/libpfm4.sh, build/config/libipmctl.sh]
runs-on: ${{ matrix.platform }}
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ docker-%:
@docker build -t cadvisor:$(shell git rev-parse --short HEAD) -f deploy/Dockerfile$(Dockerfile_tag) .

docker-build:
@docker run --rm -w /go/src/github.com/google/cadvisor -v ${PWD}:/go/src/github.com/google/cadvisor golang:1.15 make build
@docker run --rm -w /go/src/github.com/google/cadvisor -v ${PWD}:/go/src/github.com/google/cadvisor golang:1.16 make build

presubmit: vet
@echo ">> checking go formatting"
Expand Down
2 changes: 1 addition & 1 deletion build/integration-in-docker.sh
Original file line number Diff line number Diff line change
Expand Up @@ -70,5 +70,5 @@ GO_FLAGS=${GO_FLAGS:-"-tags=netgo -race"}
PACKAGES=${PACKAGES:-"sudo"}
BUILD_PACKAGES=${BUILD_PACKAGES:-}
CADVISOR_ARGS=${CADVISOR_ARGS:-}
GOLANG_VERSION=${GOLANG_VERSION:-"1.15"}
GOLANG_VERSION=${GOLANG_VERSION:-"1.16"}
run_tests "$GO_FLAGS" "$PACKAGES" "$BUILD_PACKAGES" "$CADVISOR_ARGS"
2 changes: 1 addition & 1 deletion build/unit-in-container.sh
Original file line number Diff line number Diff line change
Expand Up @@ -44,5 +44,5 @@ function run_tests() {

GO_FLAGS=${GO_FLAGS:-"-tags=netgo -race"}
BUILD_PACKAGES=${BUILD_PACKAGES:-}
GOLANG_VERSION=${GOLANG_VERSION:-"1.15"}
GOLANG_VERSION=${GOLANG_VERSION:-"1.16"}
run_tests
Loading

0 comments on commit 05a1cd9

Please sign in to comment.