Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude the tests from wheels. #218

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KOLANICH
Copy link
Contributor

@KOLANICH KOLANICH commented Sep 8, 2022

No description provided.

Copy link
Collaborator

@lucaswiman lucaswiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be sensitive to how the wheel/dist tarball is actually built. Using python -m build (as suggested in this guide), the test files are included, but using python setup.py bdist_wheel, they aren't. But I've also seen a blog post suggesting you shouldn't invoke setup.py directly.

I haven't kept up to date on the many changes of python packaging, so it would be good to have a "recipe" (or eventually a script) to do releases. Could you please combine this PR with #217 and add a DEVELOPING.md (or .rst) file with a "Releases" section describing how to do a release? If I understand correctly, it would be:

  • Tag a release with git tag -a VERSION -m 'VERSION' or something
  • Some command to build the wheel and sdist, e.g. python setup.py bdist_wheel
  • Upload command, e.g. twine upload dist/*

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants