Excluded native JSX elements from no-unsafe-any (palantir#3699)

* Excluded native JSX elements from no-unsafe-any * Lint fix: double-apostrophe Interesting how TypeScript auto-added single-apostrophes... * ...almost working.. * Split no-unsafe-any into separate tests * Added test cases for fragments * Added case for TS2.1 and fragments
erikseulean · May 3, 2018 · 93fd0ac · 93fd0ac
1 parent c86193f
commit 93fd0ac
Show file tree

Hide file tree

Showing 9 changed files with 55 additions and 1 deletion.
diff --git a/src/rules/noUnsafeAnyRule.ts b/src/rules/noUnsafeAnyRule.ts
@@ -15,9 +15,10 @@
  * limitations under the License.
  */
 
-import { isReassignmentTarget, isSymbolFlagSet, isTokenKind, isTypeFlagSet, isTypeNodeKind } from "tsutils";
+import { isIdentifier, isReassignmentTarget, isSymbolFlagSet, isTokenKind, isTypeFlagSet, isTypeNodeKind } from "tsutils";
 import * as ts from "typescript";
 import * as Lint from "../index";
+import { isLowerCase } from "../utils";
 
 export class Rule extends Lint.Rules.TypedRule {
     /* tslint:disable:object-literal-sort-keys */
@@ -387,9 +388,34 @@ function isNodeAny(node: ts.Node, checker: ts.TypeChecker): boolean {
             return isAny(checker.getDeclaredTypeOfSymbol(symbol));
         }
     }
+
+    // Lowercase JSX elements are assumed to be allowed by design
+    if (isJsxNativeElement(node)) {
+        return false;
+    }
+
     return isAny(checker.getTypeAtLocation(node));
 }
 
+const jsxElementTypes = new Set<ts.SyntaxKind>([
+    ts.SyntaxKind.JsxClosingElement,
+    ts.SyntaxKind.JsxOpeningElement,
+    ts.SyntaxKind.JsxSelfClosingElement,
+]);
+
+function isJsxNativeElement(node: ts.Node): boolean {
+    if (!isIdentifier(node) || node.parent === undefined) {
+        return false;
+    }
+
+    // TypeScript <=2.1 incorrectly parses JSX fragments
+    if (node.text === "") {
+        return true;
+    }
+
+    return jsxElementTypes.has(node.parent.kind) && isLowerCase(node.text[0]);
+}
+
 function isStringLike(expr: ts.Expression, checker: ts.TypeChecker): boolean {
     return isTypeFlagSet(checker.getTypeAtLocation(expr), ts.TypeFlags.StringLike);
 }

diff --git a/test/rules/no-unsafe-any/commonjsModule.ts → ...s/no-unsafe-any/default/commonjsModule.ts b/test/rules/no-unsafe-any/commonjsModule.ts → ...s/no-unsafe-any/default/commonjsModule.ts
diff --git a/test/rules/no-unsafe-any/es6Module.ts → .../rules/no-unsafe-any/default/es6Module.ts b/test/rules/no-unsafe-any/es6Module.ts → .../rules/no-unsafe-any/default/es6Module.ts
diff --git a/test/rules/no-unsafe-any/test.ts.lint → .../rules/no-unsafe-any/default/test.ts.lint b/test/rules/no-unsafe-any/test.ts.lint → .../rules/no-unsafe-any/default/test.ts.lint
diff --git a/test/rules/no-unsafe-any/tsconfig.json → ...rules/no-unsafe-any/default/tsconfig.json b/test/rules/no-unsafe-any/tsconfig.json → ...rules/no-unsafe-any/default/tsconfig.json
diff --git a/test/rules/no-unsafe-any/tslint.json → test/rules/no-unsafe-any/default/tslint.json b/test/rules/no-unsafe-any/tslint.json → test/rules/no-unsafe-any/default/tslint.json
diff --git a/test/rules/no-unsafe-any/jsx/test.tsx.lint b/test/rules/no-unsafe-any/jsx/test.tsx.lint
@@ -0,0 +1,15 @@
+declare const AnyComponent: any;
+
+const nativeJsxFull = <span></span>;
+const nativeJsxShort = <span />;
+
+const nativeFragmentEmpty = <></>;
+const nativeFragmentFull = <><span /></>;
+
+const componentJsxFull = <AnyComponent></AnyComponent>;
+                          ~~~~~~~~~~~~ [0]
+                                         ~~~~~~~~~~~~ [0]
+const componentJsxShort = <AnyComponent />;
+                           ~~~~~~~~~~~~ [0]
+
+[0]: Unsafe use of expression of type 'any'.
diff --git a/test/rules/no-unsafe-any/jsx/tsconfig.json b/test/rules/no-unsafe-any/jsx/tsconfig.json
@@ -0,0 +1,8 @@
+{
+    "compilerOptions": {
+        "jsx": "react",
+        "module": "commonjs",
+        "target": "es6",
+        "experimentalDecorators": true
+    }
+}
diff --git a/test/rules/no-unsafe-any/jsx/tslint.json b/test/rules/no-unsafe-any/jsx/tslint.json
@@ -0,0 +1,5 @@
+{
+  "rules": {
+    "no-unsafe-any": true
+  }
+}