Skip to content

Commit

Permalink
nilfs2: fix problem in setting checkpoint interval
Browse files Browse the repository at this point in the history
Checkpoint generation interval of nilfs goes wrong after user has
changed the interval parameter with nilfs-tune tool.

 segctord starting. Construction interval = 5 seconds,
 CP frequency < 30 seconds
 segctord starting. Construction interval = 0 seconds,
 CP frequency < 30 seconds

This turned out to be caused by a trivial bug in initialization code
of log writer.  This will fix it.

Reported-by: Andrea Gelmini <[email protected]>
Signed-off-by: Ryusuke Konishi <[email protected]>
  • Loading branch information
konis committed Jun 11, 2011
1 parent d409905 commit 071d73c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion fs/nilfs2/segment.c
Original file line number Diff line number Diff line change
Expand Up @@ -2573,7 +2573,7 @@ static struct nilfs_sc_info *nilfs_segctor_new(struct super_block *sb,
sci->sc_watermark = NILFS_SC_DEFAULT_WATERMARK;

if (nilfs->ns_interval)
sci->sc_interval = nilfs->ns_interval;
sci->sc_interval = HZ * nilfs->ns_interval;
if (nilfs->ns_watermark)
sci->sc_watermark = nilfs->ns_watermark;
return sci;
Expand Down

0 comments on commit 071d73c

Please sign in to comment.