Skip to content

Commit

Permalink
MIPS: MSP71xx: request_irq() failure ignored in msp_pcibios_config_ac…
Browse files Browse the repository at this point in the history
…cess()

Produce an error if request_irq() fails.

Signed-off-by: Roel Kluin <[email protected]>
Cc: "Ithamar R. Adema" <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Ralf Baechle <[email protected]>
  • Loading branch information
RoelKluin authored and ralfbaechle committed Sep 30, 2009
1 parent c2e3214 commit 9718426
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion arch/mips/pci/ops-pmcmsp.c
Original file line number Diff line number Diff line change
Expand Up @@ -385,6 +385,7 @@ int msp_pcibios_config_access(unsigned char access_type,
unsigned long intr;
unsigned long value;
static char pciirqflag;
int ret;
#if defined(CONFIG_PMC_MSP7120_GW) || defined(CONFIG_PMC_MSP7120_EVAL)
unsigned int vpe_status;
#endif
Expand All @@ -402,11 +403,13 @@ int msp_pcibios_config_access(unsigned char access_type,
* allocation assigns an interrupt handler to the interrupt.
*/
if (pciirqflag == 0) {
request_irq(MSP_INT_PCI,/* Hardcoded internal MSP7120 wiring */
ret = request_irq(MSP_INT_PCI,/* Hardcoded internal MSP7120 wiring */
bpci_interrupt,
IRQF_SHARED | IRQF_DISABLED,
"PMC MSP PCI Host",
preg);
if (ret != 0)
return ret;
pciirqflag = ~0;
}

Expand Down

0 comments on commit 9718426

Please sign in to comment.