virtio: fix id_matching for virtio drivers

This bug never appeared, since all current virtio drivers use VIRTIO_DEV_ANY_ID for the vendor field. If a real vendor would be used, the check in virtio_id_match is wrong - it returns 0 if id->vendor == dev->id.vendor. Signed-off-by: Christian Borntraeger <[email protected]> Signed-off-by: Rusty Russell <[email protected]>
erimatnor · Jun 12, 2009 · c89e801 · c89e801
1 parent 594de1d
commit c89e801
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c
@@ -61,7 +61,7 @@ static inline int virtio_id_match(const struct virtio_device *dev,
 	if (id->device != dev->id.device)
 		return 0;
 
-	return id->vendor == VIRTIO_DEV_ANY_ID || id->vendor != dev->id.vendor;
+	return id->vendor == VIRTIO_DEV_ANY_ID || id->vendor == dev->id.vendor;
 }
 
 /* This looks through all the IDs a driver claims to support.  If any of them